diff --git a/CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckFalsePositiveBigMeshTest.java b/CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckFalsePositiveBigMeshTest.java index 5d9a00a91da725e6fdc71f73ca50ca6b1f7e54ac..d83aa851815932aa5e1a8ccbaf2329f2548eb8c5 100644 --- a/CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckFalsePositiveBigMeshTest.java +++ b/CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckFalsePositiveBigMeshTest.java @@ -19,10 +19,10 @@ import de.hft.stuttgart.citydoctor2.parser.CityGmlParser; import de.hft.stuttgart.citydoctor2.parser.InvalidGmlFileException; /** - * Additional Test-Cases for known False-Positives for self intersection. - * These tests use building models which have big meshes. - * Excluded from Maven test-phase due to the limited memory of the - * CI/CD-Runners. + * Additional test-cases for testing found false positive self-intersection errors. + * The building models in these tests have big meshes, + * and thus induce a spike in memory usage when loaded or on starting a check. + * Excluded from Maven tests due to the limited memory of the CI/CD-Runners. * * @author Riegel */ @@ -40,7 +40,7 @@ public class SolidSelfIntCheckFalsePositiveBigMeshTest { /* * The examples have no actual self-intersections, but can contain other actual model defects. * If an error is detected, it is thus required to check if the - * False-Positive self-intersection triggered it. + * false positive self-intersection triggered it. */ if (building.containsAnyError()) { Geometry buildingGeom = building.getGeometry(GeometryType.SOLID, Lod.LOD2); @@ -50,7 +50,8 @@ public class SolidSelfIntCheckFalsePositiveBigMeshTest { CheckResult cr = buildingGeom.getCheckResult(check); assertNotNull(cr); //Ensure that the found error is not a self-intersection error - assertEquals("Known False-Positive self-intersection was detected as error", ResultStatus.OK, cr.getResultStatus()); + assertEquals("False-positive self-intersection should not be detected by self-intersection check", + ResultStatus.OK, cr.getResultStatus()); } } diff --git a/CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckTest.java b/CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckTest.java index e6cff8ebc9bd37a7ed77c1f1edef0ce0afe1e43a..1aacfc900ce5858f1f0c9c4b7906aca741c2d097 100644 --- a/CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckTest.java +++ b/CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckTest.java @@ -90,7 +90,7 @@ public class SolidSelfIntCheckTest { /* * The examples have no actual self-intersections, but can contain other actual model defects. * If an error is detected, it is thus required to check if the - * False-Positive self-intersection triggered it. + * false positive self-intersection triggered it. */ if (building.containsAnyError()) { Geometry buildingGeom = building.getGeometry(GeometryType.SOLID, Lod.LOD2); @@ -100,7 +100,8 @@ public class SolidSelfIntCheckTest { CheckResult cr = buildingGeom.getCheckResult(check); assertNotNull(cr); //Ensure that the found error is not a self-intersection error - assertEquals("Known False-Positive self-intersection was detected as error", ResultStatus.OK, cr.getResultStatus()); + assertEquals("False-positive self-intersection should not be detected by self-intersection check", + ResultStatus.OK, cr.getResultStatus()); } }