diff --git a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/check/Requirement.java b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/check/Requirement.java index c9608b85c5eb05cc96f45cc24bf94950acb1cba3..d9e4ff53ec791e2d8e39984504e8a2118a1e4601 100644 --- a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/check/Requirement.java +++ b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/check/Requirement.java @@ -128,12 +128,9 @@ public class Requirement implements Serializable { return false; Requirement other = (Requirement) obj; if (id == null) { - if (other.id != null) - return false; - } else if (!id.equals(other.id)) - return false; - return true; - } + return other.id == null; + } else return id.equals(other.id); + } @Override public String toString() { diff --git a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/datastructure/TinObject.java b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/datastructure/TinObject.java index e2b57f0e6b0545c689d7c58fbda129b58655a7ae..03f5f1a556caf8933149824f7c6839b9dd6ad88d 100644 --- a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/datastructure/TinObject.java +++ b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/datastructure/TinObject.java @@ -18,6 +18,7 @@ */ package de.hft.stuttgart.citydoctor2.datastructure; +import java.io.Serial; import java.util.ArrayList; import java.util.List; @@ -38,6 +39,7 @@ public class TinObject extends CityObject { private static final Logger logger = LogManager.getLogger(TinObject.class); + @Serial private static final long serialVersionUID = 1910744427384724422L; private final TINRelief gmlRelief; diff --git a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/datastructure/TransportationObject.java b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/datastructure/TransportationObject.java index 0670026d9e0792d2c1dabca97acb1dfd8b146cb7..d3020ea53520707ece384ace8de109db8cb420c3 100644 --- a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/datastructure/TransportationObject.java +++ b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/datastructure/TransportationObject.java @@ -236,11 +236,7 @@ public class TransportationObject extends CityObject { @Override public void unsetGmlGeometries() { switch (type) { - case ROAD: - case TRACK: - case RAILWAY: - case SQUARE: - case TRANSPORTATION_COMPLEX: + case ROAD, TRACK, RAILWAY, SQUARE,TRANSPORTATION_COMPLEX: AbstractTransportationSpace tc = (AbstractTransportationSpace) ato; tc.getDeprecatedProperties().setLod1MultiSurface(null); tc.setLod2MultiSurface(null); diff --git a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/math/ProjectionAxis.java b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/math/ProjectionAxis.java index 296316678473f9370847e7fb871c876284612fdd..15e0494f12c59a571871185d988f3f7b9c12b61e 100644 --- a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/math/ProjectionAxis.java +++ b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/math/ProjectionAxis.java @@ -134,7 +134,7 @@ public class ProjectionAxis { double x = (d - b * y - c * z) / a; return new Vertex(x, y, z); } else { - throw new IllegalStateException("Unknown axis: " + axis); + throw new IllegalStateException("Unknown axis: " + Arrays.toString(axis)); } } diff --git a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/math/Vector3d.java b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/math/Vector3d.java index 200c35040214b87a4f417e7e6409512ca9471db4..ab5f495feea7441312bd8203cd10da69084d0488 100644 --- a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/math/Vector3d.java +++ b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/math/Vector3d.java @@ -240,11 +240,9 @@ public class Vector3d implements Serializable { @Override public String toString() { final int maxLen = 5; - StringBuilder builder = new StringBuilder(); - builder.append("Vector3d [coords="); - builder.append(coords != null ? Arrays.toString(Arrays.copyOf(coords, Math.min(coords.length, maxLen))) : null); - builder.append("]"); - return builder.toString(); + return "Vector3d [coords=" + + (coords != null ? Arrays.toString(Arrays.copyOf(coords, Math.min(coords.length, maxLen))) : null) + + "]"; } @Override diff --git a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/parser/ParserConfiguration.java b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/parser/ParserConfiguration.java index 3420d4bd6bd0edf82ebe4c0fa359020f7b1ad08c..3d88acfc5850598c59eee426773b2379d5be04e6 100644 --- a/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/parser/ParserConfiguration.java +++ b/CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/parser/ParserConfiguration.java @@ -91,8 +91,8 @@ public class ParserConfiguration implements Serializable { } private void createCoordinateTransforms() { - CoordinateReferenceSystem tgtCrs = null; - CoordinateReferenceSystem crs = null; + CoordinateReferenceSystem tgtCrs ; + CoordinateReferenceSystem crs; synchronized (CRS_FACTORY) { tgtCrs = CRS_FACTORY.createFromParameters("Target", targetTransformString); crs = CRS_FACTORY.createFromParameters("Original", originalTransformString); diff --git a/CityDoctorParent/CityDoctorValidation/src/main/java/de/hft/stuttgart/citydoctor2/checks/util/SelfIntersectionUtil.java b/CityDoctorParent/CityDoctorValidation/src/main/java/de/hft/stuttgart/citydoctor2/checks/util/SelfIntersectionUtil.java index 8a35ccf843d24616913d57b1f2a47c1f3f10d907..27ab75e84d5e7792168c97ade5dc2318babb7709 100644 --- a/CityDoctorParent/CityDoctorValidation/src/main/java/de/hft/stuttgart/citydoctor2/checks/util/SelfIntersectionUtil.java +++ b/CityDoctorParent/CityDoctorValidation/src/main/java/de/hft/stuttgart/citydoctor2/checks/util/SelfIntersectionUtil.java @@ -412,7 +412,7 @@ public class SelfIntersectionUtil { Triangle3d t2 = p2.getTriangles().get(p2Index); if (t1.doesIntersect(t2)) { logger.trace("{} intersects {}", t1, t2); - logger.trace("{} intersects {}", t1.getPartOf().getOriginal().getGmlId(), + logger.trace("GML-ID: {} intersects {}", t1.getPartOf().getOriginal().getGmlId(), t2.getPartOf().getOriginal().getGmlId()); return new GeometrySelfIntersection(t1.getPartOf().getOriginal(), t2.getPartOf().getOriginal(), t1, t2);