From 01724c50cd19eb9013b1e6d06820024eaa1b2e33 Mon Sep 17 00:00:00 2001
From: Eric Duminil <eric.duminil@gmail.com>
Date: Fri, 11 Feb 2022 17:44:05 +0100
Subject: [PATCH] TODO

---
 ampel-firmware/web_config.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ampel-firmware/web_config.cpp b/ampel-firmware/web_config.cpp
index d40379c..26be17a 100644
--- a/ampel-firmware/web_config.cpp
+++ b/ampel-firmware/web_config.cpp
@@ -136,7 +136,7 @@ namespace web_config {
       Builder<CheckboxTParameter>("dst").label("Daylight Saving Time?").defaultValue(false).build();
 
   /**
-   * LoRa & Stuff
+   * LoRaWAN
    */
 #if defined(ESP32)
   OptionalParameterGroup loraParams = OptionalParameterGroup("LoRaWan", "LoRaWan", AMPEL_LORAWAN);
@@ -144,12 +144,14 @@ namespace web_config {
       Builder<IntTParameter<uint16_t>>("lora_timestep").label("LoRa timestep").defaultValue(
       LORAWAN_SENDING_INTERVAL).min(0).step(1).defaultValue(300).placeholder("[s]").build();
 
+  //TODO: Use those parameters
   TextTParameter<17> deviceEUIParam = Builder<TextTParameter<17>>("device_eui").label("Device EUI").defaultValue(
       "70B3D5...").build();
   TextTParameter<17> appEUIParam =
       Builder<TextTParameter<17>>("app_eui").label("App EUI").defaultValue("00EA07...").build();
   TextTParameter<32> appKeyParam =
       Builder<TextTParameter<32>>("app_key").label("App key").defaultValue("81CCFE...").build();
+  //TODO: Save LoRa session to hidden parameter after first OTAA successful login
 #endif
 
   OptionalGroupHtmlFormatProvider optionalGroupHtmlFormatProvider;
-- 
GitLab