From 16097a292741db71a92cc5c43b11abfa03b4af2d Mon Sep 17 00:00:00 2001
From: Eric Duminil <eric.duminil@gmail.com>
Date: Wed, 16 Feb 2022 14:49:30 +0100
Subject: [PATCH] Note
---
ampel-firmware/lorawan.cpp | 3 +--
ampel-firmware/web_config.cpp | 2 --
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/ampel-firmware/lorawan.cpp b/ampel-firmware/lorawan.cpp
index c7302e7..dfb256a 100644
--- a/ampel-firmware/lorawan.cpp
+++ b/ampel-firmware/lorawan.cpp
@@ -98,8 +98,7 @@ namespace lorawan {
u1_t nwkKey[16];
u1_t artKey[16];
LMIC_getSessionKeys(&netid, &devaddr, nwkKey, artKey);
- //TODO: Save session keys to EEPROM?
- //e.g. with https://github.com/Edzelf/LoRa/blob/master/ESP_lora_tracker/ESP8266_loratracker.ino
+ //NOTE: Saving session to EEPROM seems like a good idea at first, but unfortunately: too much info is needed, and a counter would need to be save every single time data is sent.
Serial.print(F(" netid: "));
Serial.println(netid, DEC);
Serial.print(F(" devaddr: "));
diff --git a/ampel-firmware/web_config.cpp b/ampel-firmware/web_config.cpp
index a3451ac..e8fa324 100644
--- a/ampel-firmware/web_config.cpp
+++ b/ampel-firmware/web_config.cpp
@@ -255,8 +255,6 @@ namespace web_config {
iotWebConf->setWifiConnectionTimeoutMs(1000UL * config::wifi_timeout);
iotWebConf->skipApStartup();
- //TODO: Add callbacks
- //TODO: Save LoRaWAN key if possible?
iotWebConf->init();
--
GitLab