From 9f3c1eb6b4a030e29cee1249f80eb976cd47db27 Mon Sep 17 00:00:00 2001
From: Eric Duminil <eric.duminil@gmail.com>
Date: Sat, 24 Apr 2021 19:50:50 +0200
Subject: [PATCH] co2_sensor: co2 is unsigned, so cannot be negative
---
ampel-firmware/co2_sensor.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ampel-firmware/co2_sensor.cpp b/ampel-firmware/co2_sensor.cpp
index 895e961..f17e0f7 100644
--- a/ampel-firmware/co2_sensor.cpp
+++ b/ampel-firmware/co2_sensor.cpp
@@ -235,10 +235,10 @@ namespace sensor {
temperature = scd30.getTemperature();
humidity = scd30.getHumidity();
- if (co2 <= 0) {
+ if (co2 == 0) {
// NOTE: Data is available, but it's sometimes erroneous: the sensor outputs
// zero ppm but non-zero temperature and non-zero humidity.
- Serial.println(F("Invalid sensor data - CO2 concentration <= 0 ppm"));
+ Serial.println(F("Invalid sensor data - CO2 concentration supposedly 0 ppm"));
switchState(BOOTUP);
} else if ((current_state == PREPARE_CALIBRATION_UNSTABLE) || (current_state == PREPARE_CALIBRATION_STABLE)) {
// Check for pre-calibration states first, because we do not want to
--
GitLab