From b1023818a3992dbb072ef4b05c8737e43c0fa40e Mon Sep 17 00:00:00 2001
From: Eric Duminil <eric.duminil@gmail.com>
Date: Sat, 9 Jan 2021 00:21:39 +0100
Subject: [PATCH] Notes
---
ampel-firmware/ampel-firmware.ino | 3 +--
ampel-firmware/util.h | 1 +
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ampel-firmware/ampel-firmware.ino b/ampel-firmware/ampel-firmware.ino
index 2713e2d..9e2ee0c 100644
--- a/ampel-firmware/ampel-firmware.ino
+++ b/ampel-firmware/ampel-firmware.ino
@@ -76,7 +76,6 @@ void setup() {
Serial.println(BOARD);
#ifdef AMPEL_WIFI
- // Try to connect to Wi-Fi
WiFiConnect(SENSOR_ID);
Serial.print(F("WiFi STATUS: "));
@@ -126,7 +125,7 @@ void loop() {
}
#endif
//NOTE: Loop should never take more than 1000ms. Split in smaller methods and logic if needed.
- //TODO: Restart every day or week, in order to not let t0 overflow?
+ //NOTE: Only use millis() for duration comparison, not timestamps comparison. Otherwise, problems happen when millis roll over.
uint32_t t0 = millis();
keepServicesAlive();
diff --git a/ampel-firmware/util.h b/ampel-firmware/util.h
index 0ffe5eb..2997933 100644
--- a/ampel-firmware/util.h
+++ b/ampel-firmware/util.h
@@ -36,6 +36,7 @@ namespace util {
}
}
+//NOTE: Only use seconds() for duration comparison, not timestamps comparison. Otherwise, problems happen when millis roll over.
#define seconds() (millis() / 1000UL)
extern uint32_t max_loop_duration;
const extern String SENSOR_ID;
--
GitLab