From 420073cac66ad17eb97a89735a8bf151e2f7e297 Mon Sep 17 00:00:00 2001 From: Gero Lueckemeyer <gero.lueckemeyer@hft-stuttgart.de> Date: Sat, 28 Oct 2023 00:27:41 +0200 Subject: [PATCH] added resilience against incomplete test results --- .../dtabackend/utils/CompetencyAssessmentUtil.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/de/hftstuttgart/dtabackend/utils/CompetencyAssessmentUtil.java b/src/main/java/de/hftstuttgart/dtabackend/utils/CompetencyAssessmentUtil.java index 4df6521..bf8b636 100644 --- a/src/main/java/de/hftstuttgart/dtabackend/utils/CompetencyAssessmentUtil.java +++ b/src/main/java/de/hftstuttgart/dtabackend/utils/CompetencyAssessmentUtil.java @@ -45,11 +45,13 @@ public class CompetencyAssessmentUtil { for(Result currentResult: resultSummary.results) { if(currentResult.state==Result.State.SUCCESS.ordinal()) { TestCompetencyProfile currentProfile=new TestCompetencyProfile(); - currentProfile.testPackageName=currentResult.packageName; - currentProfile.testClassName=currentResult.className; - currentProfile.testName=currentResult.name; + currentProfile.testPackageName=(currentResult.packageName!=null)?currentResult.packageName:""; + currentProfile.testClassName=(currentResult.className!=null)?currentResult.className:""; + currentProfile.testName=(currentResult.name!=null)?currentResult.name:""; int testIndex=testCompetencyProfiles.indexOf(currentProfile); - sumSuccessful=TestCompetencyProfile.competencySum(sumSuccessful, testCompetencyProfiles.get(testIndex).competencyAssessments); + if(testIndex!=-1) { + sumSuccessful=TestCompetencyProfile.competencySum(sumSuccessful, testCompetencyProfiles.get(testIndex).competencyAssessments); + } } } return sumSuccessful; -- GitLab