From 1c83b9013fcd9b6bd681eaa6c08620068455392b Mon Sep 17 00:00:00 2001
From: Gero Lueckemeyer <gero.lueckemeyer@hft-stuttgart.de>
Date: Mon, 6 Nov 2023 13:05:35 +0100
Subject: [PATCH] changed competency display to full

---
 dta.zip            | Bin 19148 -> 19162 bytes
 dta/utils/view.php |  16 ++++++++--------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/dta.zip b/dta.zip
index 3dc4044545d887c632ab5dd8f94f236ef472dcb1..584b43be9a249b7909d4f5d6c23209410e437f2a 100644
GIT binary patch
delta 2702
zcmV;93UT$!l>yq70kH2j4VY+VSBa$i{V)mu0M(QHHXVP`KoI}m#P2XRK0pzC#F&7n
z=lQxs(Ew_UF=QzVG?un$w}<%n?#}GC^a(6?aGnp10^OaN-_FeL%+78fJo2XA#S4uF
z^ruz;W6S1%pC0oCxMO(jx+8pY6Q)9V%|>G;f7e}q(m*2lFYZIsKIag)V=-qwZ^FV2
z!DJ5jd}MzG!ncN@z-|JVGita#%-oSRUJwg<7&;^FgP3v<+@A#~T>f~`c?U1J!+mDM
z+i+-GCcLst?gShd!lWm`l#gI28A+1ogrcWV;4c?BGhw+-4Y-BvJ{)sDz~68;5)yN)
zf$K{y6($J053WaqRYbf1n~8+BUNZXSAQ6t`NXCCt*W>sF+2IK1mTkk3Lm2RJXxAh)
z_J$8f{g-dv_2HoN5k4Gry9b^A#}@V$Qx{wLF;~2-nP*$b8b{?bM=TJ$0`RPR_!4Oj
zo*cb8>VL#B!1JSi=UJ}@&);<60Nx&S`$vcGULADd?Yr*VH@#<dfF9?>l{l=^@mSgk
z)i{6Rf?0NujQb-RH$a5;2&U|qqmfN+9V0#lrt2*>+fQ;~w(CsfSR+Luw4*UNuBbtP
z5FbQ-H=obz6DO38XDj-k@et8mykOca2;jZN=e=+^vjQ^DJAqi?J2eCTK|xP^myPTN
zDqmU0b|;ouBR^*|j%NFYk7=-+1s0mwoHBoB!t0V8$KwP74&S_f`=;}((;svWUO$62
z7z|}ioM0(+FcQpYErnjcuD-x^m`Du>9snby;oJ(s*^K!MoL4hD>XvkWEMXx`0ZPV<
zJHi^Jew1}hfMD0;2M8BTpQCgX?sE^N(?}BzJ{O_y06DKS$pC7oFP^j;c3=WO#-V>>
z(yUkxDjEtAR**pbk%%s*(bsZqX}GGX+KfOXmW!<SoC|XbIE`67d44$(jHY-xlooF`
zCtP$9kS%(u?YZyHo+8<h1-z1llSNQ%r5Mvt$iPM`hvSghW=IPG>en<m`W-2t1{S$2
zE@59BcaH0wM1W(F7I%GgpqXbO8EJow`@ZW3>0v~yh!Y8YWF%0CaU~w-&4-bILtN5C
zr3&pf+=8oDA?c73^o-=BdsgAQ;=4kyPYY!wB`s>kwJK)QNQqK|j9RMbN4Ia?s=*yd
zEAnSfeJ>)9kxo|6E4<!@b;9dlG>ldWQAKb3q^Y&4tY+2os5saJ2~-UHNNazPo?fXM
zF^}X=Q<=1g8+~=4{JmnJqljRT4BDXO&mK3M*;Pl%elYYO62r8Y=qTY~!3PpB8a`Cd
z08aH9D3{iOoN^3JAJ+sOQI%tj8V7Pho)~7S-6D$(NF7{o$F%qwMU?tCnLbTkZsKT>
zCJckQZ(%CZY>uqsibPcd14DmL68@sa&xq&Z&$TfritQKxk1>e;{)nU(brk4-A?Q5i
zW6L2`jnO(L#vGaP@PP7Y@KAr0=1OWN;w+nT#6>`g9&#26%(G=Sh6$w?iu7<0rOl_D
zjc5|jmka_#^2v~b3}`=;{?(_hFJ;%RJ2yVJ@@%vi6iC(Dnxie_m?nRUrgVnn8j4VM
zc&A#gwTe-81w~J_W+=w!U!l)eP&`+y8H&`RDA&Xlq=&f`_FCTJy~xL;4l>r7dCEm{
z&+6^$${-lUl&Mk6E>?=|s`aV1&f>=B>L#Il=84517QGEO<$q8*2p>6-xY}x8)#gQQ
z$S&$bWGTX-J6e<}xA1>#vyao{M<>@XQZ}#|0^wyIWs?L~FnfT+vz0L>M}0Y~q+I|i
zPm1&fpJ=+55PiBP6@TqBQm<{Nc#41PC5uLh1JpM-VInF!!V^zYRPc#1!CG3!8|Nm;
zQr29TW7l?Vx8l}jo5T-({Lsit(;4C!ILtCP1a1fX?Dtf$;xd1d9>Bds342h)>cAEu
z%W9<z;Qf311Q^BY4Y>9QAR6py04dKocWX|hy<m51O@65v%MHe!mKpN4yr?r+9U`r5
zvpVcXaM9P!vvcWJ3Qq54`518~4)+@Zlh%6t-v_s=0G;0bA~9#;bvkvj-I)3WS<r3-
zpMM`KJ|5!JvI2jhzsB)S;CUOjX(h<k=l+GvNEO`i|BA+1r&nNKSyL}c-?GTQEVNhm
zyA!qkzAelD&BQi|-M_GzkbFwnPz!OQ&uXFmTS_BalA;^b74?eppehU&4_zV&`9kTz
zXautC2zVAE&+h||nN-Xlaxv%JiO<<(tz4e6ICRVsmsWpsg4UHZQ9wyevxnmH<;;`R
z6!nX^Iwwur)L#FVN^XhvgDI|rX?-Ct{?)VH5w936qo#Enmx1IS(?u3rkEiOqmf`Z7
z^xev33ok)^ZQmv?cq654%6L&GwFRp0gSPA$|GaUd7*~j_UB=^+qKWI&S+%v*hem&#
zhDYkI&$55>0xv1y@sue-6uAI-S{2AkTC!hqA||J$ta#Rdjp*(Wx<hn%YB@zwKqg#O
z<d814ja$ZYv^hW>K40EKqEk3XTudE})%DiyjrqX3Nv$!t%l66`0U~RznBA+^@S^0M
z;w(?P#<t7EF|#YmU#gAx0Vp$7Wy)4gtnxcWD1(1rBS{eGcQsCGbxfr>{!_)sMng9W
zZx=mP?Ad+v)QXVFtfko)U-a8YfXtq1D>=J9<5ckfN5(DAILRTTG;DD~+iqo|5@&b`
zqLSaX1-OXgG+C~{Ige8;@iws^2z5D5NY?e@*5i^D45+D+;HV<oHB&d~m`{sotf!0w
zTSb3?g0#aaH^0DqYMImJO%1w*LBWlb8HGt3)j9&3kHyWQ>ys&&Y2p|3VCpO(1nT}^
ziN-GbHy_G2+Enjnr*;k2-K9wOKt(*a_l+mIsiBMK&c5+P_ds;<+}$^x!sU{(NurYy
zXx5%`^`}*L7jVjcVG}-Z@Vd3;<pl|1n*e`*dc<U^2q^*G3~1K?vPEl4`~musUika9
zg(6O?tzE+-?dU0HcPZ-cnA^0tg}PUg&Oq-^<F!y;&Fs<A+d(rV3$X^KeOW~9mQ^^g
zFvh$1_Q{muKE4Yz=05F-#T4I}N(vG+pbZjb5Ed=!xU)hL!P>mwl8VDS+Wx7on!10-
zKV?@724dlDGcz}O$!-yo>LR3l1gZyUw|mR;WGqbj1K0T@%+-}p^&surU^utmIQBx#
zR~zqa*C^KyXO6n5?FMoJgC(nF3wmuXei;z3U=s3pQm@=1(YT3kC!7s&Z$}4i*+-d^
zrEUD_1op|<Xp?Ud$bsW-=~P;dwI6@*S<UL>qer{-v?ZG)h1YNt<$5VsNgkeiXF-^M
zoUbU={;A#)uTGJtBoEH9mw4_rN#{9mkyxkt=zf!XoPFvM2;6oHpPA=4ODu3ms?E~8
z$rwuN;LEnB5zS}K5$(_XW%be?7qG0as<ea_3tA^+0n_1Mg}T;`R-!lk$e%w;HY3_q
z-9*@$QoFyZ)V@4k(7PeA$Agv+KJ${76Qu-t<<P|<IPTf#^rdi^($;*PGxnHj*&Csf
zBK@8x{`a#sLB|LUm}q8KiKP4eFbV(w)sqTJGX}wFQg5jclMqQBlVM680Y#I5N=63e
ILjV8(0KN-2A^-pY

delta 2683
zcmV->3WW9Al>y9^0kH2j4ehyQS9~1m-XaPB0I-w%HXVNwF%bXX#P2X}e1IbOh%vbn
z^*mpfC>lVGF@}_-z{X{lbi0T6`0mcMyX+GvcW|DMGv2|ro%wZUIy0SiA3U0lrx!0Y
z8qgg(0Sq0N1OA;dA;BNQYu_K>lbbM>a=O=OOw{+fFGdX<r2fZ!XtdxQ0)HrHOz=IJ
z`ytrO1Hpd>P9TNT4<&Y!z`Q}j7clV$&Tvj7=wav$xBxlkAi0<X$XtDS(Rv3jxW@%^
z;ceJ=9UERbHunM!3}MofV9W>5SA^7%=Y*o8QQ$WpDKqK#UJbZ|?E;Ru2=F`HjhMs~
zYv2n-rNShE7vN86U=<P1!DTWTTQ8aYVv-2Q@f3gIu|MVb0m<PEXO8PapF<e%Vd&P>
zXzUFij=C@3yz9b2>mz(PXtxhq-H-d&TaJBf<;Pspawb#PLDD!Y!8|!f@EX9g_Tft$
zbMWNo)lv5&&H<hubz9Fm9eDnx4F~Y{pxr$>eD~_04R7DI-@fTQs{?d6C#pnYm5hf<
zPbh!J0hi2igJj+xQMmykbO$hI#~hVxbLSZGF|hsVe7*h@73TWhNX<18BtknHg6GQ`
z1PJj#WOuXKtUmHWWq7V0A2c2!nu`}~mjwa5clfLm_9sq2>Uk#-D}1MBz#nAvMEGpr
z&QbVUJFY)+>>AlQn{ZUyH+)Q!<t%Ve&Gvtoc_Us|!*M=dAmQ-M>$h)O&syDH>)`b>
zXoAI%*T@SNTzdn_to;Sk>(})MxDF#F0m%bkBs5%GK{%N(F~@Z^aieZY_s0qr!jzzS
zOt>eVLF!9c*8~W5O}>Ei!4@33BXhy0$em`IP!L>(!UHm1Z<GPl&>yBsZ`grJ{4;+H
zJ)2g=Vp7pmXkY~g=pTjXavFUt*OrE>o2q*eh(vRd_MUTTj{%o4t0&JdM~qPwPy0&a
zdwU};+X%>&9o_a^_>-qNtj_{o$->DZsP3l-(^N>o)_xAhA#?4J90AJLwmI4z37`fJ
znJl`nFP=X`f2R=OT$ILrfd(|0Iyirfq{fBtMUb9GM2aX8(??bUg$P&TdER^&F*rn*
zCM#8FHsKary$VT(6r*RvC*89O-!<JOj0HK$N{U<5jJ_%+(@3$>lZ;xbXh*ki-KxPI
zNDK03PJAySi%~{a&kMZXgjLMzU^T4$l0g--`IDqpin5v&&!ggG6C_Zv@K1kQg7oxC
z)rx5(KYLoGMcinsJ#Ft53k^jEy=2lBxj%Qfx0m%giuZ%Qct`}(R$?NAhXor*z!=z2
zJp(w^tEWxc1aitS3~k&HbTq0QYt-0N3-ZJ;OZ66MtViPDl6$tpR|ulizPqUU!+7}o
zt?(%aE7x=6sR>ALCLGL1_V#}U&T&OStAT~_Cy9ZP2eje^`EzApiUK@F!DEc1zdtOQ
zg&qz1Ux++U`Oxu5R72E`je$p{Jv^Xf8m1^e%5~LfCgW6_62*Byg6?w`N=&v@N`_hG
zG?eM-AWD~yIUCSQo-GIjh~$%{7+KJKsO+mtU0<rMZGUEc-p`XUB2a%AsvT@@Y#GJ$
zplDrZhFn7yS`Y7Z>$Ux2s9iFmqgyj0hG<`*;7dk4*R7cmDbJ`J<C39=IX8PPuklV~
zV@d`YZB3@yL~_sS&8%mTi~`Hps%1TvCcDf@)mCZT`dnSdluxE|-iujpLQUHrlukk*
zC1O`wZmY($s13<QeQ1AJYGB_V%*%vZc(&fgY4M|x8z?Co-7JalGLN#Ef-jld!@-lK
zfhITla#l#&092kCnKM4oaxWS5>6#M!wa++uWjn=F{8uk=8YKo$Ut@#`tLzL<yhu^N
zCrSrvX&J9wo5V|Nb5){U+qT|{`<qR&Klt&(AURE^iDzIiiv)iWxEt`Z-&n<h%W!%C
z_YxuOKoH9VTZAktl`??$@9h#`6sy<Z+97~wvdaOaEa%+$oJe}X_Iyp=)eO}JV@Ga=
ztS!&#47@`mwN1Rkb{H3J?K~TodAZ>9W|of;XJT-_Aut*F<Nr3eSsCc`<`=O!6RR^R
zmTgDXC&+@f!}x#v+gR~&AD@<03B?M-JAvh`-KLcwTb=tCG9z7e$KMqLUuRZjUs_l%
za^JAhzNofWce@jH{=O~C|INfEiQT`jnNV~}$xsVXqQBKb{kL?CYDtQ2P}ifElm~TT
zuz2zkamW`+4+aBJWk<lX5Os(jOqor^{63d6&b|1sUDbce)k%#<XDxAQHOFXGNfQ~A
z)HFNDE?>?(Nlnqbh--4(v`OvtZ>i*#NIw{(Crrx=Y4NX9*B|hTwZ9}BQvEF%lY`_R
z(`^>ljHd3ql3<FogO{MbHg6}5WX_!72~?$&Eeo_KO&npeEROUAoJIdR-W<XawhWQV
zoDS`9uIhj0l<Jq9P^o32Dv&i`1G><I>WOYNMN1|hJSqysrKWYuT0qIcY4O?OVi28)
zL85SdP*pecq-&$|swHNy)XH|Q=#L}aELm&IJZh2iR&kc6KttDO@|d}mqV0duv-n(X
z#GOE^uBwu%a)LSoTS`oatVR;n>3cO!MNL#{D5rl@MYbi8Gg)=ej6d9f^aA{Ox|paV
z%JyTTQQTW-ONGAp4&N@qUiPe7^V#;vrH21M-feJlNd}>~VT%{KZdqW-Z^m>~5eq+_
zvp7u>FA9r5>U(cek**gv6qlT!M@^LkM-|DgSlUU){F0@)o-(3r6io`;4#(X70<*DW
zj~9RUFX(Osg-8-+6l`4->i}FnlsEgnAXPHk#t&%0)LB6Y^wq!;iCq>qAF4LmD(`0h
zbq!YCkVtkmMLf56jVHQ)VT$L@uJJ^-J52H1-8G)Vm65VVVv<@IR+Ms8rDZn~aLImQ
zBi{4yCbi*}1O;M~1mN_DNmUV20=gd1wgG=+OVN(}1LUQw@b^m#S)5i{+lEKdF%!)8
zQrO?Iw#m7LrWcLQK<-atU#KozcF6U%Pz{MAHo&wijp#kM4hIg#cpqOZ8B^TH*PMo2
z(9T+p@pY)A%uoZ`R8a=ukW<Iq7_taf<^`8@9NyA4Qg=0!J^qwk80g9Qbd#02)=Gc2
zi<m?gA?+eiGeFzjd!8p{VbUM?-XEc^wt{K~Y1azFwf)9(=X$-mcoVxuxqdkD^!;l;
zPzx9wRdbuu8*%Y_et<=mkjIO9=@yCRO>|q~q>p<$I!4Pr%A6N%VoxW~PfkbcY>Pnl
zJby!@GBT{)fX_<S93MT}uB9!=Bq@KqfuU&AOPNaY@Z1{<!u;cGMT_=NwU*dBMV690
zILB5p^*2d6&w+`=GBro{o6O_vQ;$I6wp$8jpW`gCKq09%EA=LGD5--l+MY&ZJ{!(x
zcj_;zmv*>>MSWGLCFCr~PpAT>$G=K_Ssk@R@9&X4muyCitGWrZ6{U8utkf~SI9@Qj
z_prl*mJfnWlUEKE2YQjv$09iH+3578aG26Gd`UC5m}=R3o@zw;?M?jkvqVA12o3GI
pWmkM0>fRy>006L)7)mn*SZ~0RHIq<EJpnh9j!H%b*h2sS002v>814W7

diff --git a/dta/utils/view.php b/dta/utils/view.php
index 2d0b469..a5a4b87 100644
--- a/dta/utils/view.php
+++ b/dta/utils/view.php
@@ -56,7 +56,7 @@ class ViewSubmissionUtils {
             $html .= $summary->unknownCount() . get_string("unknown_state", self::COMPONENT_NAME) . "<br>";
         }
 
-        $html .= get_string("success_competencies", self::COMPONENT_NAME) . $summary->successfulTestCompetencyProfile . "<br>";
+        $html .= get_string("success_competencies", self::COMPONENT_NAME) . $summary->successfultestcompetencies . "<br>";
 
         return html_writer::div($html, "dtaSubmissionSummary");
     }
@@ -209,10 +209,11 @@ class ViewSubmissionUtils {
         $showncompetencies = explode(";", $summary->successfultestcompetencies);
         $overallcompetencies = explode(";", $summary->overalltestcompetencies);
         
-        $index=1;
-        foreach ($overallcompetencies as $comp) {
+        for ($index=1, $size=count($overallcompetencies; $index<=$size; $index++) {
+            $comp=$overallcompetencies[$index];
+            $shown=$showncompetencies[$index];
             // If the competency was actually assessed by the assignment and tests, add a row in the table.
-            if($comp!="0") {
+//            if($comp!="0") {
                 // New copy of base attributes array.
                 $resultrowattributes = $tablerowattributes;
                 $tmp = "";
@@ -220,13 +221,12 @@ class ViewSubmissionUtils {
                 
                 $tmp = "";
                 $tmp .= html_writer::tag("td", 
-                    floatval($showncompetencies[$index])/floatval ($comp) . "% 
-                    (" . $showncompetencies[$index] . " / " . $comp . ")",
+                    floatval($shown)/floatval ($comp) . "% 
+                    (" . $shown . " / " . $comp . ")",
                     $resultrowattributes);
                 
                 $body .= html_writer::tag("tr", $tmp, $resultrowattributes);
-            }
-            $index = $index + 1;
+//            }
         }
         $body = html_writer::tag("tbody", $body);
         $html .= html_writer::tag("table", $header . $body, ["class" => "dtaTable"]);
-- 
GitLab