From 31a0e011f9e49b7e3a5701897289260e2dceac8c Mon Sep 17 00:00:00 2001
From: Gero Lueckemeyer <gero.lueckemeyer@hft-stuttgart.de>
Date: Mon, 6 Nov 2023 22:15:32 +0100
Subject: [PATCH] changed competency array index access

---
 dta.zip            | Bin 19159 -> 19164 bytes
 dta/utils/view.php |   6 +++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dta.zip b/dta.zip
index 2775cc1483356b63dea0a9551ba63eed5cac91b5..a8faaeccf30697a162d13dad3847bb97551c0946 100644
GIT binary patch
delta 2688
zcmV-`3V-$2l>yw90kH2j4a~7-SJn`)C^8BF0N0cJHZFgj=j#&X3~(A_3|Yzojiqhc
z?IAwCyED5jeFDoJoaaNMKzC>6w==UdyR+LzPrQkD`BI|+y@?gT$g(-$r^kE&?g-wx
z?hv2chKUefv(cE!-*wj?H;_pFi~A6@&p8C{NX(een=p4nFqs2BA6kL%twAWTn*inv
z8?FyicW8f&=EQ;?hR%@tASN6H_oo30mp@*$kKq+}xX)~O7Y=O8gg2JSoqz*FnDiu=
z@F5H&BT4d-P;?av{N*BNCM?&f0k^Q-hZF7x_#5s=LSl|JaDB<8!UTc$!S#r+iiqc6
zGm+5NOGdvKB*L*A$#~*=9KRqt9O2BeZ5VI}13rHW?V6;<-tghD_xk9#2m9@h@L|8x
z*>Cqg?qP2+aj})3aK+1-dbWkEaa2BY#2mpZ053WRuaRc|+2NbR-bWk*ygcl+Uv#_h
z@~8v*@NU1;J3Kgkv)_St$DMaa-4}I$F6YFRIIPm~NZJY2IOKv^c94wwBN{hAg!T|7
z?1X=#kxg!$AU+1B>&@5OPjX?l>x|`CBSj*#!x1>Hs6l`bA4PsQo6YKDCzOt7EBc`E
z7|~q5WZEnU;Jw9X-Ec6q0y59BK&<ecngRcypl80zhV~qludHLcW6P|OpR*}Pvwg$I
zG+5383(ag!m^0>eNsi-j0s#j{Z{HoYU$lRF{r3Lb7tjKOp{%hJETr~_f*E@Yp*L@;
zFK`paQUihqz({F0w}NmwW&RxJ)zpr<CEcG&SO`;qk}>6uu!gB0WnB{>*fse9!Ufak
zC>@3S+(YR!(u9N0Md&*~&g+abfEwzHC+&tEn81%w=$JGs7K4h0LWC70P=6$%t7(7q
zwOm^ou4<|_BM^z@BI~{6!khq3V^&X|UyTH#DV`6c#hcAB7aas-i>_*W>ATbCNH$;r
zuVmq55mfh5jA<xjU}G<b<AB*_NPz(LYnmMWjucP>i(D2%*cZp0VZ4(Fa4gc|u8$5h
z^(-VKt#RLX{UAMzh!t@np-+qi3Ne4K#N)jEI1+GxAx%`O&}zXQxPBdy4k<w|NKU$E
z6}~IJO9cBAC@U#xQ8UJ>m`x)kN)0k<siGg<y>q7q_aLpvpE>otiabU-Sv{}tdJ9$w
zuY=Jr_DYB<dgCWetyE<-tDYyt!6rzcV&F$wgY@)T)rff{f11jqMcnACedT}e6$2eb
z1pQ>t28BO+)NE#>j+Fgq;6EmYX)n=H!sCJuBw#drsGb3w>eW{+tphpb7@9t=2|A)G
z#~L;E<%B#n%u>5W7VDEbxZsXy@fC_F^=~qLn!Mb^QIIAK{h4p!Ql!}&S|=5Wss;w8
zo+SN6!Ow{2;?I>iDa!4b08f7~iT?hKq?dIR=zk&UJm(|JAytjgIws~Ex#Hmgt)sz1
z{n0X4QZo^+vT2Pt4@l7i&O(9fY`Gf41*I2?^l%WR%_p1<X%f#C3<5;*$&i8!Xg!wx
z)uXPjW!H{7Gd}O-*=R8+kgC|4qb=i@CW@wXhU5l{P<A+0tvB|HS$2O3MOU?EC`RaC
zq0g64yi~0jid0aPF>wj$K`z4H$XmP{`Iyu}##&QPxk&C=y_Jm&f>BPH7`1G$Qf!yS
zr`jru8=tG|gz~8;=KWaoCft<&LFpiT<V50X%Y9Xw7qua~s1K2)2nX(PUZ&i_v-Lhs
zlOLU2!${f0W(b6rd6a)$B)EdveI%YP%`rLZt63#&15o**NMG=&rh5s|ryEl7H$Efv
z%67`9__tmXG)f$xzQzd?QP~lmdXl1oPqh-PrFFb^Zjvlz%~fmc+P3Xh+}doi@Pi*e
zG}fi*72-KK%wlZ_+z$Bp@2O(NWh6a<2Z<7Ppory(Ekc&nN*RB^hYxlMFv`_yaP1I4
zG}z?;Ql4|+Vos#JV0*D9A8JN&gR!G9L*AAbbq>)X(%L4`VLO70zIKtFOTSWZb~nrC
zh;wnc-;kKJ;_-hU+^hn0cK3_KoQv1#)XBDE>Qk(Owj=oB`&jYu0H2l>2>lg~cM8v2
zyG<)WwtDSfSQ&q*f;;|S(TH_=1@@&i^`i6*i|mU+dv&)vQS0y9vi#pnY_hQX7d8`;
zPbnK}Ax`vJE!2NYX=F=Mbc4F0UQ!-Zg~8&XOC%v*DBT|pL6#i>&qCz+ec&;ZiunUB
zW}G|mIlHWt%TpGIj#=W;YEICqk|qi$scCjmT)v!nnwo#2ei2vaq-m4d>)%qzEzy23
z!AO|a7xLm?J=-1fim_+Zw2tF4klYix$YSg9RGn8cTzr$hTe)iCC8)2hJH!QVq_j+#
zFJh@#CZIY$l0D;Jw{8{l3X!$SczjYcah*D=wwC(P=#SIzP~G)ebe`iSB|M%oMTjEj
zAWy3Tc}agu_DfF0<g}C(&l<2H-5o-Ah%Qe>Q#7BfDsn(qTE-n?G1eTMHlHo-Aki5d
zBo3wy#_D>Jd+lmq)s)tl+GRUsjQ^1>m(1;D5xgjQt2pItt&%?@+hyW}*%jq4)kgdP
zl%c9}$wq0de9>meHJ&1t39ykY66kj|UfAjwOjCagXUdbhd3dw@sj|=Z^QTshOy(`k
z$M~w>E>dLnTwBT6_9>@=|35cwaLP#zA*Er96WaD(CNFV@*B~nSjaz_W94E;l2Io9Z
zvBdktejwEKI3Zcri<^%tR?w%WN`j+`Y*$R&q+@<U(pb-!4K~UI1!)HpZhnE;#4;y~
zyBdFV4};PhDKkoxHmY?9HXn)G1J@^0GSkE_=)u%kLI~6i!V-;L^>06xZM3c4&0g&W
zth!B+?1GAT?(P~-bXP+c&%IsaiEe`E;<>+TJca8eWs^i_S)f^c%2lA2-Cn>c`-P2p
z-@yyln%5U3h)vS_*%6beBBTU#J)ms^$d-StE%68FOM2n&*A|L6tG2cckF=wwnC&f4
zf5+UW;1=p$N;(I<KaXRfyqwvk(A!2cB!O51)2=L{_RA_ASeWBoeE(!Zc^}_~8gZX?
z#bSbQO(i9X8qoHLRuC2ib=+H_h+yTq;EKw_TiODuu9~{XKV_E-`eN>FGBekD$##Dc
zlj<U*Jp`%;XuCVhi)1WZ^arl<N0_T4q3S`}wZU+1A3641%~u<5ZP#e6A5I;0SKAHb
z1O`ji%jWdrT>Ls9V96xp@uXh5MWS&N-*z}1;NFgo+_H}{XG@#-(<$tev(Y-=B9MK@
z-O#DD9BVh=vzpb%M~}AaX$v;V5?+79QIzYYTqSvU;hhCx{&BvdRQsoTOB|gdPe~qJ
zU@!69O%|OOz(r!6>ZAKj?s5K0k3itITlmbpz^lXphossp&6|v&qz=Aldmhnz)*R99
z%wJY7?Q#K&`l?!%P_UplAq$ue|0>kQcC-?`>qq`vvKi5?>L$Wgl-m7erS>uSctP`Q
zW`_qYAAIH|uO~_g^wOb=MR44+(dkR!Fr}sWLTBtT)v|X&B}Mv8PyFu}vqC|}2o21!
uW>?k_uqZML007sM6-qM(L^#Pd_7IZ+Mjn%FN*)16lZ#452IxZo00004t2ZP7

delta 2683
zcmV->3WW9Cl>yh40kH2j4O(etSJjRmKP?IX0Me8EHZFhS`MN~W0BVdeWGM?YmbPiP
zhxqvJ&g{1I2`qPTo)3)z-JO}=&dkp2&Tbz(@}}O!3ylW!r&a)C%jSTe9`gmbV|eYl
zBYbibrb2klMq?&_*Ij?oKqC1s?nBf*=McDKF=sw+!om%~WDfXzWCg;vhM~Z20+=&u
zxIWC>ku`r_5DR)3IwS6bm~s%@p9Lsf{&>-O2QRq8eP+YkaA;d5ys}L01RNN`q$k0Y
zk6<VnNs{M;qNh;cFBds8VYyBXxP|RL9CJUw-*7h)5_7D9>q{;bCJ4L_u1ADbM7#i-
ziG;RZGWz8p5su|Z##7hh_yyVF2<Mh<!;nK5@Ns`=*CaLeh7U*mmv7$nq22iiAKKk+
zyVL)8fW5`k#a4dI6)$V%*%q?KQTfaf3k0tKJnJ65M4I-KqgO}$k2nT+e$?+g>-FII
zn=Z8BZM)k)I(+x4-G#UBx^Lg~p49<*oD)~#uujKgX(v?Uhzn-fK{D=-Xxso1+9Q~<
zV~&4DHo0|-_!yY3x7chy$%WajGm&GB6p7G|#^AW31_45R5c%DFKCe%lP&%Hi=!3>X
zM04?iX|o`J_ZFY`!r{yc$UN@^VukP24EP5HJ@H*OvKOd)WgXj{SZ0m<oXt3z?HfL(
z!EzQ@Xl8TDoC&W>avYBn2snK6`t6&}vrd11&}qMZ1}!ic%9=RAQtDtNm~pTadi}ck
z0@q<8H6VBZjFg6RD+p&Z<}Yww&FrXK(*3c7g)jvu88hw(Yn1v?)-?fwU6UUmTrho(
z(owk2J(Nx(O*r^mguVmhyv`&8sG+`i(r(y+3H%s`j!Cm(IjCqTL|8!r^+zJQoJN0N
z%eAH9s-|i)0+CoQvfgtp%qieBX7%Lx<w!7^;^|OYyxE*^(M3SE=&82nzB_x0WJ4D4
zN)}EQLG>WTn1(_IHV$$)4w-F+6bMkirpeLoNC7pl$Yn8veR145#yg1s$09B6`shG2
z&q6ZN8uxwI57NVkSP>@@`p8J25aWMJJkFaBBLRmP(nO^StrpyZt5+fEkP`Ha<fMC6
z;k)9yLa<MPvXYV(HDj!b*)&q3)F7jlD*DmwTeoU(2hxiCnN#13$YZ3F)$<Ckw_u&{
zIv5S(poFNRH-6I8T2)rF>UmTgY=Q(T27aV9NKda+jhILBr>RU@#Erf>Q2u{jG0;&&
zFh~Y%Q24XQ&1N?0NZAjD{zGDz_7WW>JS_M?0!G7!>KVYPUIXRQI*?P2q3PqApd+es
ztWo1YPRJ9(EVWx?u>q-r3+|W}U!#ap|0dI?$;(X~1!=-CnEMtkMVif#bzG6CYG7dM
zNzz{w{ET=m{#=`rqTG%N@ECuS=<m-+dRa$-{uh$YQ$DsFQq>r(V`9#cD;^%uIvPCG
zA1!kwH52hFo7RYnfD}FCEEKrTma8#bP<o+A4+l}&e9GB~Ch>g9AV4Ia3@ONf)<fxE
zed_vBcI~=z<MTnDjTVCfsfw*R+A@x5qG(EINUos>WrugF_1Zx(%dUT*=&9BW#Tfl7
z^!W;k=c+YBkqU}3Caxeo%thF1d5iZVACo%BSZn4f7s)-Vx3ZBzFv=-Yqm~U;itVcS
zR9k0p<8yVBP(Jg-Vi1eohMV#~C>?~4oJd@4wXbUPqBdj~^&zqp;m{o|%9LApw%NyN
z@}rY$7%7|B41w@6kFtM@1XnP7fW)(vIVMMaIjf{y04iS;=?gy5bT1+LbWJM$+GnI*
z+fMlu|JF-_Mu`K|H#lJ;Dm%gxPf}FyiB^KOw2n8<O_HUoxo(YJ+qK<_Tbpebe(>Xm
z#=11ULOcV9S*{I%+W|lOJyoo@jHCx}FHyoC6tOz7MaZ&RDFc6a|K2_UM!9+et~~;X
z2D=(S%5%<L%!#xY>@L>iL(N!jF!mH?$lLOw&LBEOTH7W%>_%|W*UqzZ=~oI)?`HWN
zaV8G;8xoUNJpS*4+f{&0?|zY(Gx0i|I@xYaeS%fcZUmoyA1gi{;?uGMp})rQPT+YP
zw`nEF*022wD<gkZaL4~E8nI5Vz`nAkUX;FNk$qWcukLpzYW;m%mj9cHZ5DR_!e&D9
zDP=<~#ECwuh5BzPjciGZZcta$E6RhaFjzcvi6rC;rR~uOWZ4n$EJU8)2Ocx2m_OuV
z&bbqxv&&k!JY{j{m?bW)<^-)PX`+CVnr08h<;$5TsVRTz7jbn?nzpIE{w<Z<672_5
zjD%@@Aus;bv)vJ|7zaj8>o_h0$vvivEVdp`)p;$$<u~cOmCF`hg8JIJO<eFsO3Re_
zB9@wE0;=<amh2k;ym6zLSctAw#^jTti3`<Py|vVbMt_`#N9wZAvhxCODdG8)DMA#v
z0C`*$$XkC}vR`r}Cg-IrdDei9=<*QyLv(v8nxpw_RgnX_)G}@v%dzI*bohLE35gEj
zAn`DDGFI0M-5Zw!>*ln^+%DTHV*-e5xngp!3gJb`JH=VP<{H~B6UWT1C~v7Y;s>D2
zRFx~Xa$>c-Q-m`2HInrK{jSDqS{+kqj{j6CQa67EZ<jh%;@N%b)Jl)ZjHQ_v-}2i>
zcFZ1WD>=J9;8gJcr^PJ}ILRTTG;DD~+djyoB+l>#L?ypx3owA=Bw0q^oX07ac$L@>
zgt{3gB<p%{-*L$b2GmqZa8!})nu(iq%uh%f>nZcVRym*`?QqJ?FEF24=5%>YgRWpu
zVk3WLMk&%pwT{5%V{von`eaIGn)n4hm^w=cfx0|cqOr^V&4;p$cGUaXrd@+|7b%hr
zP!Z4VedCF)Y3Sm)vu`}nB@kUaclV8_aI>UrlISc5Gz(9;;?t^&3pi!Jun8YHc-LC<
z=7I#VO?p2)Vlq{Plz?sqv}*v_inS&F0DXT+FZ})5LJ_Cc)~?}^cJvgpy9Mg+nA;TG
zLf!jFXQ20|aV(VgGJ6zyJ7|U^5NlxCmqpZ0S)~IDbG(bMo=hq4<BL#Z?$dr)O!0-O
zq#98J+8)sg!lIy#`zjO>tX&seQh9hsn?Kc6Q}_6%>|Vh@EWB-I=0-2sEn-q#gtUK;
zK=lCac4v8>jD?H-z;*rzb9E(DJxKdD7|!iCj=fOx)y50kHCpS3Ge=$1b^|$q!IG7-
z1-&yDzX=FfE(v)&saI~1XxzlN6V8UXx1-ax?4!)F(l-8d0{i4_w8^&!<iK&abSf>!
z+7I}wX7%yWquqMil1;LN*Kic&dMSTbNgkeiXF-^MoUbU={;A#)N2kbBk_YG5OFVa*
zMdvwikyxkt=zf!Xoc+=x5V-9YJ~PkpDzU&JsWwaVCSxe6gD=~jMl_!_N3=ilm(@#q
zT)?uvs+J`bEGSOM0;a>i3U#L)twgW+kw2GgMzpKCiLf=Lc7Ii=Jw9I0Jew@p<3Y;@
zpLxlfiBbZ+Z|GtX9QSN=`cgPdX=%R88GB5%>~&B{k$%Y&|N8~AM?uC24O(etSJjRm
pKP?IX0Me5hN;3wlKg>v~5R)KD9+PoO9sxp=kV-}d<3j)d001|AE!qG8

diff --git a/dta/utils/view.php b/dta/utils/view.php
index 862480f..044ef7c 100644
--- a/dta/utils/view.php
+++ b/dta/utils/view.php
@@ -209,7 +209,7 @@ class ViewSubmissionUtils {
         $showncompetencies = explode(";", $summary->successfultestcompetencies);
         $overallcompetencies = explode(";", $summary->overalltestcompetencies);
         
-        for ($index=1, $size=count($overallcompetencies); $index<=$size; $index++) {
+        for ($index=0, $size=count($overallcompetencies); $index<$size; $index++) {
             $comp=$overallcompetencies[$index];
             $shown=$showncompetencies[$index];
             // If the competency was actually assessed by the assignment and tests, add a row in the table.
@@ -221,8 +221,8 @@ class ViewSubmissionUtils {
                 
                 $tmp = "";
                 $tmp .= html_writer::tag("td", 
-                    floatval($shown)/floatval ($comp) . "% 
-                    (" . $shown . " / " . $comp . ")",
+//                    floatval($shown)/floatval ($comp) . "% " .
+                    "(" . $shown . " / " . $comp . ")",
                     $resultrowattributes);
                 
                 $body .= html_writer::tag("tr", $tmp, $resultrowattributes);
-- 
GitLab