From 51c41667a8a9d302b8176043189c18aabea19286 Mon Sep 17 00:00:00 2001
From: Gero Lueckemeyer <gero.lueckemeyer@hft-stuttgart.de>
Date: Mon, 6 Nov 2023 13:13:40 +0100
Subject: [PATCH] fixed competency evaluation order

---
 dta.zip                              | Bin 19163 -> 19159 bytes
 dta/lang/en/assignsubmission_dta.php |   2 +-
 dta/utils/view.php                   |   4 ++--
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dta.zip b/dta.zip
index e05f7438d215d35ee77e876a9c4e822fe6fc289c..2775cc1483356b63dea0a9551ba63eed5cac91b5 100644
GIT binary patch
delta 3024
zcmV;>3orEBl>yh40kFUY4QOd*SJ{$&BajFH0MoP01x5saA9&ls%95E)TptGg?@l`=
z=YldaU}iJ{eqxA}30iby!0gbE2WrgRFzA0z)w<iwY$4;>HSbQ37x6TEhBMnn7On?-
ziNg-lMMEEhr%#F@U(}7U!{2F$%-yDnLLP(}nBmM2(r{+A+QuIGxjq`R3YF9W_5=s;
ztS%SaY+Fr#wvfA8)}<N%VYWm&VcH}m(xLI3VOirp8pDhx+6*dr75y;Uc324C67wrA
zZim-)fD4JmD1h$Jp9!FldL1o-f8mA7XRgsQK}xM-<vrvWAYP*cgjLo?Qg`W3Ho)l<
zGXe3689@a+L3A!fSEirwhRxdY79$&{U>fJr6#|QYktteZKaRr`NTJ(BZ7@fk!Z5e9
zd2QLU$pjqpoZ{&vPVT|eg>M%=#W^-eS&D^eOU08g*draQ_?%TDUV1*GZVHRW<i+DX
zcuP0@Chq)gKND_~z}Ui4fRdjBcG68WG1}FNa4#14uKJAE7@5_f1n)%d882yXFz-+}
z8_;QgL?_5|9+`%A0zB`5X=EqB3jvr$cY?g=kx7gvxJw?FMtTCg?1B4ZK3#F8U6ICo
ziavAN!_&x5k-=a4f<MIvkL?Nm6yCZm4g3_`x-Jd<6x_Hkjr$ZE9Qcjk-wE~&UAXXl
z=L39yZJrY<WDcfANeRK}6|zx|1ZVz&pJ`)%=)KUc3Xgb<wD`ie&GpOTIYS#ZkKU!A
z2Rj-UD`+_yuKYa;ZSXW#N))??N{K_L{ktv)iVM3->K8dtMh;me5cv!oSNUu4vi4V0
zFEb105zu0~Ev{ml<4+igGQUTtwkZ{ZhaID9aOWcXr)l`Q(&HiMae&P#dT9(h3IFnc
zFAy|OIA-_yD73l=;w_5*{VY4IWxvSnQ#|1RRQyo2>`@83H2uA7rM1OTh08147k8ne
z3AiX6PGQL9t`BMF&F_=zSLmN-*{u90RGXt=m?lsfG?2(gGPC3+6a(DE*N{J*1tffs
z&_CI|JJogy0{<*RXDrmiu8#T&YvbF083prGfpU(mSA5b7Z9<O3E8gE>Owtph{dZL3
znZC!ejeqe~CAmLx$;<zp67jCFqlB-l%;eNW?KI-?7XH8M6s|-)l`_M_HN}7VX?eYC
z)1c70C<Hzh6de)`w%x;5nsk%+)_BbfHQf65Ev4tEy6^AJ*Wq(~)wE41D*yg}H<NdJ
zo89jY{I4TQ@3fvtY;4ByJd(I?4E0aBr9#oCvY-aF${%TJYiLJ(&-j8xefGB5<0@>o
zJt2;`u;oBoZfV*z+Ww}#y5G@j`;DCyI!g5O#5|Ma%+P?Fmp0OwK$s8xH_%x|`oOVA
zv)Kzc|M~OrM2_VKf9*=;g!w^#ITwcH#5P_cNVN?<TDv1ptJV=1kjfU^M0Zc}5__*r
z54&?W)mc`{=;HgK4NcwEX8u|N-RfME$defA!uG9Qa{MJOZ-2exiCCW?bU9ai9e+Xc
z7le?9X(YzRPt<MdZHYSN2IF^lNuOo}j<GElj^P(N{6-t$(K#sSD^N?biVkHc4O(et
zSJjRmKP?IX0Me8EHdO-7?6Xrhn*x6n2vEPK$<gmf0X4A5Wif<(aojn^JBa|tA}#Lv
z=s+{iLNd}C_kGt7(!+>Y5hoJ*$Vi|N<4Qcvn-3!ahZxdCr3$SU+=8oDA?c73^o-=B
zdsgAQ;=4kyPl2+Mk`^^%tcuw*Qliu#qn0ZA(d}EeYH$bAiu{>V-;2m&q?1O~^9rxG
zV4d(f7!Bi~gs7r7e$v!hRaUd=c~l&1f&?lCexx->Pp?#sm`C!bsZ3hLjlMci{$4TA
zQA99E25nIIv&YS5Hj}hENq+@t!Z4Wo7A{4a&5?Cnk*I25VCqTIUlja|crN~2o0Fp4
zjtTG>lj!fyNP1aEf&Leg&Qm_N98%R7tz%-&kt-e^&^j7C)E_N#B{dWADx21bi+~h8
z<SZ1p&X%h&Tu^$UNDl{5+I-5{h$iuT$sj-^pA0F;fYw9lUw!KOQe$@Qx^v_6L7t5k
zg953FtvT8<j%lK3N@qx}p$KJ%cdGT;K{3m&py;XA48<7zEA;saisz~|Ly-!KGA6Dd
zJ<LVeYk7<JA|I1F$XILUDHq8-tGBX|K`_cGQ=^s*R*LPa_><o|I)9tk41w@6kFtvd
zS1@~k#Iuz-CP#fatE623Dqj@o3qH|wFCqGLO)CD{XQW=+PWcr7)=Pp$i38L(IAJ0x
zJHiuBQdIDXR)V#(jyKLtlBKM<ZjD{rwcUzan{5_;@Z*QZx-`8)JOhVWt_^|P0YCda
zRjjy-qz7;>QNkV+v41+TMaZ&RDFb-_-aY|Fxq1VxJpzaZyBa{sbIx7NiL@8&F4p8j
z%~)<Q_7rBw+w!8$AUZ@^+a@~fMsU&B&a-prR|-z=X89a(CJy%-5|dUu{_lg^Re(<K
zevz0n@j9J4*=|gIf>qFN1fPE&D?T3L)3O4gzsB)S;CUOjX@4ci*022wD<f5K$NwuD
zu}-hRzOtrXl)hz=eOYL)?sq3@{e4@O|C@<z7Iy!_W<v5QWkW5*i9V}^`fn+XY)Oi4
zP*>C|%7dyfSUhxzB;*UF?a>Hi*%9z8M4sOV9y6(!KjdQ0xf7qW%UZcSWpU`3B`&Sz
z1g$G+qJWZ`W`7UG<;$5TsVV9gadl3bwyC}TEtT97?FUngglT;tFaFiD-4U-C2S!cn
zI4%RpJ*JB+wjNK_c`d``H|e{T%NAaO`r5ipT<}Ip%ar*dmYQV(s`G=E>>B^Paif@6
zh^|$}<ddR_3)NY@wbX}3f1HO$>ax$W^8#-v;rWy)LVpyw0C`*$$Xi;nUveZS=cO!p
z)_{%Z@(}t%bbBhAqxo!AkpsHaGHw~mvF6}(_<VT@i4Nf)@i28VR@V#N8<zv?=CsD#
zF54<&0*Gw6Vsftv;YG<i#aX`Q8rv=t$IPxMZ>cuo2cXPUl`FP#Vzs<egfjOvlJx=o
zuEuLx9e-14j{j6CQa1%}mpWDA*?sENN{`8mrI{Gt^4mvt%pPegIlDgKRPg_&#Vrmv
z$swdPY;i){KFFjb&hQ3ACBJ72Fo5GESw`QS$0?S0mDmr2x)~=V>w0nDamfk>)Kp1u
zRFUnPiJNrHPe>Z;Df7TqIiMizaLUauFrQlHbbonGgRWpuVk2cnDbhx@j=<()adYVU
zWJ+e5_ys+fI!g$Fx;$8-vCIC=hq8@!)ce_{U4wNODUuCP5zp;?<B6_m=;FDvZ#>Z@
z5M4ZX_l>7;v!ra2=qv~{3s1S?)2fRLIAy=E2_HCk*IM)Df&{TmdOtm4GF60>fNln~
zYkvUQinS&F0DVa>{QcTO5vSGGuHlh(^c1tZ1?umZ+Z5bF-TO#qp!cV7ER^>$dlY&*
zXoe&ZYhc=!Mbu7Nr2`9dyo;}%Oeyc<i%?_k(|%Y?@r9|R8c_q<9?=TIqM(lZDijf{
zT^C$Zd3Z;gKh;%J_xPvmUco>tylrOYMqMx2En-q#gtU)9^#JX5XL+8Cg^T{cb^Zu*
zbtP0iNc%Pz&h0mjy-@Sj#tYjuTI+{1M_to)137`gl9jRry)zfT2?$s&33)uJS8kDL
z+{CvN&W5<RqtmwRqs+0BaX=z}vV_-g6y<s;S4ke8duKtIf1Ix<)&8m85=W=VQ<4Yg
z*h@Tjn?>h2aFJN2`sjX>dz}5!BM`Xl7Ctl2@hY*vA*nV?^Cn{`se>=uo<=mEHAl2R
z^Ox02dtAV>zN(fb6f7uC$O5LrzY2Ay9j!#K`H?@DY(})Jx{0tgrFMTXRjEBbUeG+7
z+2cXW2cLP#n~72ay>IAZ5ghkybox>_OlfJp%Ncu2wd{3JNs)fZvqC}P1Py3uW>?vg
zej|_w007gIFh)fMa%PNHs*_PlAG4W8a{~=pX=Yc|jvqfQ3IG7olNm}g1*<>INUD=j
SN<9HWlaES92IE5j00025ozoxy

delta 3041
zcmV<73m){>l>yt80kFUY4IxlwS3RSPNRS8s0MfI~1x5sa47?p#Wy#DYE)RqLcc&eb
zb3q9iFf*C}KQY9~1SL8yV0PHY^E4)I81%oVTHWntwvh4Yns<lCi+Gql!<lUx3)h3a
z#9@c&f}xMW!zaa%E9%D9;qNp;=5A9(ArHa~%y4E1X*jc5ZDSApTpx`|g-YrGdx8Ua
zR+kHIwyh?ATgY84>rxGXFj=CVFl&+u>Ckx2u&nVPjbTO;Z330NihdYvJ1j(RiRl#=
zx5H~Yz=gzG6hL?A&je6Ny^a>azwkcg6W3^&Af?u^@E&pu5U)`J!Xj%Usk`(i8{qVb
znSgl3jG+3RAUc<#E7Q+-!DelBi;;~}FpYER3W2qM$P}%yAID(|q|oi6Hkcz%VVK(4
zytZuFWCD(PPVw{-C->m#zPAgX;v5^KEXBgKrQ%5#?2(Q|e9kHn?>wJTH-$xG^5XFx
zyrm0%6L<cyp9!}~U~FM2K*`SmJLx8x80~6BxE2e1R(-}>jLhm#fp;SJjF+@Gn0F|g
z4d^s~q7&pfk4!^50iO53G_n)mg#b*WJ3(Ib$Rx%S+$E1oBRv6L_Q3rypRTylu1I4(
zMV~qC;c4Wj$l$Mi!Jp!T$Myt&3UA$(27U@|U6+P_3U1t&#(jzn4*W*&?*#jX?pyf0
z^8voUHqQwaG6z$mq=ew~2-zq{f-`@=&$Kar^jv6Hg*QA#T72N!=JsXroS_YyH}6u=
zdmW976|@`;SN<M_Hh7vFC5qicrNklB{#lm;#f9A^^^2S+BZsUKh<pZ)tNg8aS^FER
zmzjn02xu`~7FV&$@h6N#ncpK++mwpI!;aA{xO0*H(=>ct>G2TsHo#sLJv4@$gn#*e
z2MC%c9J70U6gpi5@fOAZewH29vR~x(DIV~DDt@S1_Natin)Y6{(%Ryv!sQk2i@Q+K
z1Y8sjr!eGl*N3$8=J(0<EA-E^Y*zjgs?E_bOcN*#8c5_LnOSlZiUDroYsjC@0unw*
z=%4J~ooYJ;fqxdEF&64!S4Vw?wejhHjDq>8Ksm?GE57K3HX%pi74PpbCh3XM{yVDi
zOy6VK#=rQglH4D;<mLZPiFnu8QNmYNW^(GGb{g?`3;*AB3Rj|@N}1u|n&Q9ww7lN6
zX;5fg6apU$iVlee+wS2jO}a^ZYrJNL`fdIDmeO-n-M9DV>+m_gYTBL@m4E+#lgYci
zz3z7h{>KrecRJ4`HumCp9!cCchT5mxQlaQmSx|pk<&QMAHMFC)XMDk;K6|_DaTRvk
zo)AY|*m9sPw>0hgY=2W<-EZi%?Z(au9VPm8VxCEIX6V1oOB?A-Ak2sM8|W+}ec;%m
z+3W?J|NQxQBFA!rKX#>Z!u+6roC`y8VizwFq}u)-t=*BQRqF^0NM#FdqPr(~iLKYB
zh26QE>MW~ebn*Srg{J0eGk-0CZZ)n+<Vg&5Vf)rDIsOorw?E$TM66E`x|}P%jz1vz
z3qr`lG!kRuC+ar!wnUwBgYi4Oq)#&f$Jmw&$M6dsexi-==o}RE6;Mk80|b+gMi{fC
z4ofHv<!EMCQGGedF$w?x)|31;RRZqJvr{*l0)Mm+pngr0qu-GNYG9Ge;u7}7ap$<+
zNd!0+X>r#_2by^nl9AT9@4J4G9!A89IFZmtMgoNxSK@Krd>9Eh#3fBss?ch|Ex39W
zk`5_B&qz+XXBECHzAFU#v`|)3(xPTut70~dlqfaGsHKX2bo<t=8r*@jB7f%8_agEb
z=|^Psyu#}(SSP#=M#DHLA*$$&pER{rmDQ|z9u)_hAc2a3A88HJ(<@aY=8^nqDw7s*
zqpuE>zgG-&6cG%PK^wIE+2dw2yOXmzNq;TUgkdoEElfq4&5?Cnk*I25VCYH0U$poc
z@m&15HYP=}9RuJo2GQRik@TXD0{t%pou_<kIi#vFTF1ngBQqWzP#z5)>W|V~NzFu@
zWmAs02uRUG&O(8Cw#>#bq4YwL9uA_k`INH}P2%~IL4Zg;8B&k|t%uUT`qcHM>|@$>
z=f>xQJR2<r1yZ%P=4i_}rir2{oguk~B9tB8sn%-;#VEUiqNiFj6l3(S(B~^Co~zaj
zMQTx$YvKyh!`upcEpPE&<YQ6?8Eefv<s!Lf^;ULe5R78V)Tm__E5&xz`jg%}I)5A3
z41w@6kFrUEE0{e%;@Qd=lcT<zRnjg1l_y2|f=@KvONc&QlZwCg8L8K{Q#{4L^^!%S
z!~yCXoG=lU9pQ;5DJu9xnP4rg<BfBZWGQQ|%du;_wp(#)vrXa$KYnQBrRfau3>;>e
z8v?fje)fB+SaBIi58z&+ggq!?b$?)skY%+}2Jrs9eFBVP^#)vf1P~2&HGq`ooVztA
z(q6E;wI;vRjO7MnPs<E>TVB)|tPYXZwpkr^Be>{m=h?aRD+Q-_vwVy=6Nmc^fk|sU
z{_lg^Re(<Kevz0n@j9J4*=|gIf-Gn^g3rH?6(0}rX<32LU*mWu@Vt%Nw0{z0>vR7?
zW~2)4_<u!Xt<x*8udJyTrEgheUl!V{``w9Jf8Unn|7K#F#O`0%Oh`VZY^a4e(Py<#
z|1G7FElJT0>WX?rc~BJwi-#_egnXg2JsN>5I|81C$n*QaV<r{zhg{4#cj9w)Su2;P
zEDjyB#HH1opmilp6i`yr?0=!Sd^z(ZHAVd*uFgr*HnrEkrIK5s{a}hKVOn3vi+}ZO
zcf>2kfl<>sj>|xDkLe<dt;bV!UdwR#P5N%-vW1tRzP4@?7rc?uGG)AorDmCc>inQ3
zyT(6n+$aVXqHC2g`J`y#LUmSeE%l+%ALrqby6m&;yue#Zcs^x{5PwB3Kps~G@|KqD
zmmG=7c_~YtHDDvUJcRxb-JV*`Q52AgR~0#=OD*G;u^ep<P>0W#*O2HK4iX<zXJd7}
z#d~8yux?gs%<i(yGKPT2nk%OFsztmgd8atbv#zo2GI7l8it?9gBYptNOjVh)l@qH3
zPZ7%K*GMu1`dy8)T7Ml=X^#I?L9)@%4a3`oPZfN2A3n80WHM`MHpVyo_7Neo$J$EH
zt`9jC{QseGi$hLw2q_I)oY1xpGGU1`yaiFo@7n@g#BrJ|*WaASDVBJh*bjud9VaB~
zdU5Y@$qEM4R7r4Dk?oqPn{>?Q#WdDaMuM%PKtbB!l$&2*K7X~$>GG-uUBjT@M#_xB
zq>XAFfz8L_=Fs)Yl*}~o3wkhhmJkAUfv`klm;IX$WgG3P_p?>I2J0?UB%7cjp4<Dz
z6J6EN#dBxhc%q9Sx_IvH8&BbON!cXPNeMKIPq_lrs>=&FWxucqA2@j5TJ!dT1hGwk
zKRseHRfLp)Zhr=}YXI4*wI%)leMv9;{n|nir`6W3;gNRq6tlY&^>@r|THHe2J4t7t
z_owk%DDP(WXzA^s8Ipxq1Jk}NqISzF99S6RU3~pyN^u`wh8lC9_QYa}FHI#Ci5k!b
zi82U_7IoZNp@?8@UT{gp;T>)NR98*i<Das-1p~40wqTi=8@*(=h)H!3(mn#!1GL+{
z<#{p|CjEiy{1N8rN~n5}_H8hn+ix6uq2{ZNm$qw^>xVN(UDb92If22F)v^V>Hy6JR
z2v{%)c|56CZjor*#J3a9hPbz*6SwT6%+Zr=Kq7yV!fQB+a=nzRBoEKMvmner&R3Lb
z|5R^@SEtBRk_YG5OFVa*r1KoONUT$Rbic_x&OY@B1a7;9&&+e2B^Ed&)n;klWDF&B
z@MYW6h~~5Ai1ugxvU+Kc3s}}yRa!!e1+5dZfa&nBLfvaeE77Zd<j*CW5$&pOB5X~m
z-Cr<OYF{2N=v|T6<3Y;@pLxmKiBbZ+bLe6b9QSN=`cgPdX=%RC8GB5%?3GYSk$%y$
zK0)CG4IxlwS3RSPNRS8s0Me5zMnwihm{`M)5R(B$9<!B3a{~?KXl7SYeL2Z73IG7s
jlNCxc26H}T#HkRI0Y)B^Y)T#hMw5$5Mh53Y00000=QQND

diff --git a/dta/lang/en/assignsubmission_dta.php b/dta/lang/en/assignsubmission_dta.php
index e7c7fde..d80eaa8 100644
--- a/dta/lang/en/assignsubmission_dta.php
+++ b/dta/lang/en/assignsubmission_dta.php
@@ -37,7 +37,7 @@ $string["tests_successful"] = " successful";
 $string["failures"] = " failure";
 $string["compilation_errors"] = " compilation error";
 $string["unknown_state"] = " with unknown state";
-$string["success_competencies"] = "Successfully tested competency profile";
+$string["success_competencies"] = "Successfully tested competency profile ";
 $string["summary"] = "Summary";
 $string["total_items"] = "Total items";
 $string["success_rate"] = "Success rate";
diff --git a/dta/utils/view.php b/dta/utils/view.php
index dab1216..862480f 100644
--- a/dta/utils/view.php
+++ b/dta/utils/view.php
@@ -213,7 +213,7 @@ class ViewSubmissionUtils {
             $comp=$overallcompetencies[$index];
             $shown=$showncompetencies[$index];
             // If the competency was actually assessed by the assignment and tests, add a row in the table.
-//            if($comp!="0") {
+            if($comp!="0") {
                 // New copy of base attributes array.
                 $resultrowattributes = $tablerowattributes;
                 $tmp = "";
@@ -226,7 +226,7 @@ class ViewSubmissionUtils {
                     $resultrowattributes);
                 
                 $body .= html_writer::tag("tr", $tmp, $resultrowattributes);
-//            }
+            }
         }
         $body = html_writer::tag("tbody", $body);
         $html .= html_writer::tag("table", $header . $body, ["class" => "dtaTable"]);
-- 
GitLab