From 7e5513dcbd398f6159c51098d37dec1ff265cf22 Mon Sep 17 00:00:00 2001
From: Gero Lueckemeyer <gero.lueckemeyer@hft-stuttgart.de>
Date: Wed, 20 Dec 2023 15:27:17 +0100
Subject: [PATCH] fixed privacy code checker issues
---
dta.zip | Bin 23672 -> 23623 bytes
dta/privacy/provider.php | 38 +++++++++++++++++---------------------
2 files changed, 17 insertions(+), 21 deletions(-)
diff --git a/dta.zip b/dta.zip
index a73e57b695efc21a281c78289e3f8aa7901cb10b..41b9486a4a1b1c9127705ea7ff31518a55a338eb 100644
GIT binary patch
delta 2945
zcmV-{3x4$YxB<tw0kB&s4o-WNR|it_`|=6^0PQW4X(=CnT3K(?KoEY<uUHU*1cl^*
zx0EZ~kxD6T5keGMuDwYXeBoWUM2P>+H+%R<oHR`VAu2>{@7&kUj{V?qHqSc4Av>81
z$)+OW48NJ5E0#{#n=}pa<Q|(Vm5qkOSl<uQd^Q9Q{y7N3%{gZ>ovI5z=OeaA3l{hZ
z%XuiI%EeiKp#Y|spM=9SXK@;e=>in!S&@W1XKK!w;(08=S>L=mc+Xz(gy(+54vVu$
z1Z-afJdvFFkddCqIS<(x(a{($Nrq!11MX4~_LWGJKH~!GIXmaM#67!jc{qZ7mgYpH
z>noBxXK6-wJ&3ztk*_M$!HVLgeh@_@n(92wI4(ec4BB0YC}L-v6_QVjs87fMW*;Ue
zuiw5uVdI03?8ErzXnb(;aSy<1o??}sb3;nRStLLi8s&bX77$#se{uBeHBiP+C;O9=
zj}V`|oSYoII6h`C-yX3sI~*UKOrE{pA0M&9_eY0sk6#QJJLa5-g1{!@PPKnvz>q6n
zMAE5${1GmdkS+?@+&|}VZNSAjWb;{&W{b<+MnwE5O=en6YeI-MnX)8ReI_B^0~=}=
z7Z-zBQs`KV47waX8gx3tyLUV6F3a-tTp(<;wD7WzC*s@>7FeY9Cz&67^=A|+Qp^%r
zoW(+t1HDlB8o*LzjJ2>Ng(5yx!&w#$<|>YVj9Q2L?EF5AZDK-`A;?_J<_b#ZDcdi2
z@Ri4W!E=grCRGvgM3KB-c%TsBek_4F>?D57C8TT@@zkob*Xa}xGJrok`{*=E13x;A
z;T=-^G)SWeq=C4%4mRiC3NF>@MJ^!srC>ptDE?hVh-?i@>FOCNPaTH2^|Gj#iNv#i
zm>vlPk%I`!rH^zF^B87;=JwB(9D~ooluOu(qAo+Cr3r!ujE!ptCD!RCJ2-az3Vef(
zgyOZJtW~x0&#q{sP>IWabTqb(XZpL#UQ+o*<?>BXBc>~48zf}JfrTIHU-(KYHa<R{
zygE33|MblSS8orz=O<(D<z)ZG_~^xd*sGqihwNrWR8pkf+%tk?CRe5M6@I2gqC<+!
zxbmEdyH%*MTh(=M#A*vaoKfl^_a6CS=z+6bNX26>63N#t0IR<{+E=s#$vgeV%BRoG
z`#aXaBPZ6VhFU`Q_B!hYA*?fBat}WdUlOD(9U*!g`}ty7G<R2FSAG)V9ro~lQH!{n
z7>pYD{Z;xE+HUl#$L;i$h&f^)&UPVQBDYbVMd_Izc~}p=svL!H7Y-{#+HDjBTuN-W
zUXaEaS3C&>m%H#=L#owsP@RX@=4i-l;&y31Y@+|iG9>4+h}54;5JUfu<%c1EX?obU
z!o%);rTDev>*#Id^~Sj?agDrxmh_H9*O8-rVi$UZ*Gh1TUbDy%aEojgx;6BT<gvY?
zy|@MgL!gbtZk5fF-(1m<o<*E^NfDp%d<W_c{5A&IkooT9YuK$xlS-k)PF8oQzoi5k
znp;*t{vEAyg1v_NMtW?TmODh~48GzC3dH|c;Hq^x1wabov7zU>`tDSJGhn+ba;}QJ
z(P8fCwV%r!vpGWGUy$N>u15j2ql!I$n1h%;nxga17p!ciy;>*inri)H&X2htGbV6$
zyG4z=2*Hh;L&@a1Io)6Ab{%7rBosK++GCTX_I<ESs5(=DVEtz7mYBX(DMR!z`7P37
zYix<9M6~2k9sw@v+%1BC2V~D^;nCS!)OGLHbnLH{v&Vj{9NzHHk5CW81)Fje&@g72
zr*X{(gEfw;&}CZl9(if42ZfT_gMzQ|R{Jr`C}#AjU5^u%p3#w<42w&QIubb1IhdwU
z_V9iMb6W&+(i5TVZZFX9weMs~b1XBb(H)%B5lh}BMVa9%$*$#psBWf*HW<@E12QsV
zUk}49fpRt#Kq3WG0ok(C7z;c7T1_rPfY#vA2-_#6OcZH&QZwct9Io-H7S$NbUFk%0
zH`a^WddMp7ksV!jbT`cjme{X)>L68&fCWN$ojYE9&(d7MnYF2gjyqM&K-THMe$c{h
zaZOiWKgWMWJfvEG5ptTOVpC=pa}ms4Qj@#200g6P&7+itqjo^)*oy@6#d_l-=sAxv
z9RUW9{J&LJ7-(;K3Zkb8+iA9B?hlw;6?u+`ixw<IW1wg#c~KjcP_?8vTL7gHwTQY(
zW(q>FJXN~o%=56$_uivg0qyqoN^mh{-DNnfRkz1(JY-3K5k*es=8mS9Dmp(a0kltm
z$}iZdRN*sf<m)VN8B?_hXjU4)r77AFthr6rG|=>B4h#a)*WDVWz7ev5r|=~kv#v$-
zr6IATyQ^`Ri*oOgf!u4Nqg^nqi#@=C(DSG76$aCz5r{O_D68GcwQG%b?-6Zll`8sy
z)1!*3V_H{#G{h$*290GiHXV&9{>zA1A1cs9uNgD00z#A$wr`ELEDq*(%&68Br6iqm
znn8yqlU9rb{gx>nM*d9rxsY)^{Hqiwa>;9nU@witW_39kmd30l{c@*s+xKW>g|1*~
zWx%x_B~M&!Hrc0^15#|e;Yx6kpco|q2kBLKqmjXXFxT7R8CeY;UAF>}M-2#FEw#rr
z<NaK-U5xS8DWJ_lrS%=sy?qIJg!<mPn{Zd^0fe@+d?jUYsQd;xmW98|c4P1K&7|5N
z?9M?VSU$<Dl5DGO!l+c=CP1u=w=HF=R~|DbWVfC_MJ8M!P^};pOhb^8+iKD`&XUu5
z9rfscy#|Ip&0;I>J+i!L;%^G>Ci=RJwU6HJ^tYb>H>9keG$F5JzPh)VJC_$m7EP!s
zS0*HL4hx6Ubg6Bk+Fr6OKIEX%5Ei?;dA`U#t(>r%svyI5Aa4uj73jC*?G{;EWo#F%
z3BB*iedGWTdswqAitW#Jb5_c^Q-^4{nhw!_yv}9*8M^qAi{@dY%p5a=LN-dqH4@mU
z(cMnKKbO9`IkTLaEt|_Lx44>j8#2aWZJRJH4cao9)xO9e|CZun9{sV}QtflCiuSHo
zG1!<!1zCy(+?%6_uSX_8!}k?YdU3s~(vbd=6438#9Ld!cUk1K*b^6P4u2ebeIZ6G0
zNBz`Qb|AIm2aOnp<*>n|sp(04S94r-*-*vY)IyFN>^+BFJ}~HZrc*s$7N%>+<FZ%6
zX!&S$$GSRZ^x~yCU@;Xm2hcgb+NmF=%UJ>0>zXxI{u7n8rLtI$cYE7bRytGjI8%#N
zT9vw*Vz2#dU2CeZP${W=;FS9<f}Cc5(%J(CY~u>J2OVKlKe|+|K0AK5@8Pqn@tb4s
zVEpFA^GhqTCppcxcPPw+-cp%$RW3{OYCUdhTAANHvYiiAhtKP`H*Dw|YnapPvWk0i
zX*V4?^7tn1Ijfsj3x2bd{5sriA^i>PR}14|o`yxh?Y2Y%WbJ0q5_%KU8E;O1wx(F*
zJcBhLfaw>foQL#cgg!8<__sHGZc5ac_M9}T?^+DX&gx}`F&mY^1ovTyWoK6O-QfbO
z?$$o3w8P5}{#{S+^#gieyjskvDpngWwdv4blCz%ew@m23SD!xbZIR_Gqb-8fk=$sD
zV0%2RqM<DZJ8YZ3HHo?<_U?UuR@-0Qs8>;eKH<?{=i;l=Z6%-LH4cZtuRI&1J}|{=
zG#g!d)5Ii!MhOwU_Q`xTr)>CANPS{4Uno<EJ+^eJ?E|WERUcWpQ5g{=LOpi-Hruey
z9zN8XG^AXLy-!*V6Cp0zyFFbj>9#o+`^h+{ZBLAZ==KIzVzIjISz9^>CS|eu+4%*t
zsx+u14o-WNR|it_`|=6^0PQW4U|Bc@19WnPP&1PuRveSMSs(#<liOKg0ZEfRT3-Q<
rlbu>y0k)I*T4n(~lVDqC0>nm>5l0l0-CIrp#gi;tMh1&i00000s$H(v
delta 2999
zcmV;o3rO_GxB>XM0kB&s66<c1S95KDQzHui097sk02lz1L0KAq-5S|$+eYwRUoj1g
zS_)+8p>J~SR;is<fUjCMiXbisid;$C@CtWnMM(Yco!NtjNFA1)qNre4BzNaNc4nv_
ze@f;_tKWyaITtYH0R#L_+*Cq5h08eh@yQX)rA!9>eyHwyaXRZG4F1_21e-DjBA&{H
zo3a5c;|x4Ef|U7xT*#D9GKt$HxRKwFQwU?9PnU>+o@J5GQjl{7lBJ<Q%IfCVt9$sB
zMJ#m#xXC5~_uztiED{V{<dL3;IrCvccof8Y;$f_Lz`Ga`yOPII7Z}I&6dqYB@E(3J
zG%Ug{#3><ZyOKChAx;RcgX}ILaAg77s|lXVhpg~OVV%c+3BwCShSDu~5Ws{%CfGC!
zx&(}y;g8YXZ`b#CFueKze++MLhgWwWj&ZY`$GFNKnMTFKB;be{B}&~$E|GCX{`~fr
z-w<T@Zgera`+)4j`_bLi`FITPuWw-pH^bYz(J%KG!&|tyzrDF0pZ5U9j1f{qut~X7
zWgk?a&!o$L17St}fF>2lUEssqePn1_kMT$3%>^$`mfOunNZcTfW=c$>LS$<+g(#L?
z5Xjz-#?=;!MQ;{m%GUx7F8ZgvR;&N^Z42H)lE#l5-9~YXR(A0Te{{ViF4FqXiR*oG
zXXGk^&mxgcLN3UFjxSxc!C(b|29hLDz^1Z4OM>2iT!w)b>*fL;e?VnxpHOIMXUb=D
zi9)9_Tx87q#6q@YDfv1GnfWY|#P46sljz}YC=jsUirkP1<g%H?2P4jLtL3vPkC@*+
zyu7|XyEu17S9j;PSHp|L4*dN$x*uzIa94(+Ja}j}$3Q*=vF8R4AsUhNgKI&693cMV
zwVP9a_BmrhJ}gp>@@?Pe#gSxRWPl-HHe+BrTAl|BqHmof$Ywlp45&jqA=_Sn%egg`
zyR#4#hB`7Io18Q}_%RcxRr1dSLo$xg&5*Kof}VxitO`r6YqxI{l0cjq$OcghOYRFs
z0_Ctd=+~CIR1rX*xA2}4Hs(54hXF=GfyB6f6)Cf4_V?8{8cj$Tj>n^4ug3T9E=PEE
zedV0p4W0L+i}T^_`Oqnz!wI}8kP7n6H^-WhL`S!fuEeit7Afz78Iz7xb-VC7I4G_=
z11K$gwGx)M9G$wp?;vHd6q1Ebz@txX+*o`LmCfkP5{KQ&%Ev#e_lHK&1IyN+1e))E
z>>THp>lq^Gi7S|cUjbWTs40+9gfMi|<tmHzu7ED=#r;D#Ic;Ej6M;bmzFWs%fbECB
zc-)L%@{pk~gvmb0bKoY-vml<hfrIPbCz)c(+=oI9NwbbTj|qVXwd2KM!X%44&cr_S
z)}U(C9E#5T7gN+|Hc{Ie7n|@`BIPxIBP3-a3*@&85RLzv#fL_}H9Sl~;^4XeEdMp=
z%ivAu)j_&1as|8=^`1!Ap`-I+AAAJYh;WKkYL=qIEt7rlmcTcn$72@DjTaEm2%1Rj
zm)Q*Z%^3~DGYcap%EAdt_rP9(Zz6yPGut113A!<8V!<WfOY0W&RZ^hF`OI2>fqlUu
zI>IxD>PdR6i<m<~I6<4S2ouHsFVPk2)E*!gL}OzORx=T7u~A8b&8JezWR_M+PHnKK
z)e>6w7Wn7I*x{>b0u&XxX-sr4r@C8g3DPCx)wNS9jct{!zH|$kx*-6^_V0iydhR1N
zrn{BVnH~@<RQ(Rv;rSdJW7AN7399FNtB8tj3lWxYhIR?mt&9QP55(s{v8|v5J|(0%
zg}f)&R>~Uy2Z0?eg+uK-FU#I8$=F@XX9vF4x;p%G15Awm5~fUgG|!o)aagiJZ;jy!
za1ocRM^;*EK`w=|AZKf=)!d(H!L&T3>tO`(gt~fCEMDTYBtj!v1JfXX%k=-xP`3fl
zEg<(rdv}IjSHGhvjl%S(N0o9yc`R9%1O-i3kY4j?-%QPYaMFhokdo2&)jZ80$j4hA
zawJhz2yDnHh@}~z)q_hTpf$8;fafTMOc1F3BxcAEvA@QqidC&Fd!+)=-WV(HY9S-I
zLwdB)(cUybSRr4x)Kx5hfi`n=;dSOX|B}S1L}Ql59m?-yF&tSZ|N03G9597fU7z7U
zLhe(p@EHwb@pOj8oO^Q{)MReO0PRt*`cX{tRWswX<avbrh3e#^-E$Ts$^$eU*?*^~
z(7T=0@rW8P>?YZYy8mF{Woe2Y7c9ZY3PI9bb5WX|P`0E|orgkyq1U3<6+Dv@^3`$E
zfmP2*neNePDS@_2H3OeQdv%|Zs@;L_P9VyH!17!@(bQ6b=c!;o*#tq^0v?3)f1!%L
zO!7dhs)<3pQrVoVq6xsLTSrX=Or7QkL7UWdyM(E$nJo5``;v~KZ2(=NQLM;rbKG`T
zj!yN?<0?3o3%YiHF`ewm*}Hp*lkLF(QB+narfmb;HYz(hr9-U{L_M%l6kau^bxCgl
zNQ7QxS<h1k1M>ddAJ#hx%AwY@66+h0m3(j4sBD!T9Or=+t;$M{I%PD(_H`W9RMa_!
z@~5?m{w8o|+)cR%%aKq-LzW6wiV1V6+1IP9aj`Or&GF}dhn_vj2LmHPv8R*~Y!#Bz
z#H-Ev``FMlg{Cqt80Qh@rO0E5y1rjaq#^Y6Zg84c4M*3Fo5;L+3td$!<&y56)*Ku|
ze1+xFu_5E~S!rM8_$<Io-*~RDJn5TP5axK+FqDWr<=5QZ=io7S>Sk1&6y^*e77U$e
zR&ch{fuTizDjyh#EO)mZc`D~1JvxMgvv=5HJi|{7BgLKyBRREt0;mkwrsa(4(5nxe
z169+mI65`7=w*OTy_@i>l-4|rJM8ZKYM{bpx#>iHE%Ev(qwj23(0!4wi%+YZ%Cw87
z3^ncxUB5Q5ZmP^Y7m>ko#Te-J<`E=(tTo?N(J<nF_CRlv>ND^+#PJSMTtsjiixzrC
zmbw@d2-v|jQ@ohUU6pM)pL^AgnyRiH^}AwlCs^O-R1^*4b-DrdGEqq(F9>KYMte5~
zzg;-1vdvJc7IQYv>|#9*H$;$ydTs!f>XcP9^@>RYze=*vkG@&1DbB@4L6O0iWDFS6
z5Fv?waRKjjlj5pj3WDK}H-dQavaC|!eoG3#>DR__T~+d`VqTn{{%uB|)c=)SXY41a
zDk*nmd0kR!PiO?u&xa8@Saqf1+RS5f%!XWMry62l_a0g3{DB5HGoRw|Dl=`39xprj
z9>pK6?wMVOKyPTO0~no0Q{423KMX22+xaYif%NslOe_8q`L!Xx7>l<%yXIHwxmlRV
zWgS-`uEN-9?!8N;_A~M&B@yg`KL^OCp2T(#0(E24xPvmHQr%!HUtJjge&OIRyM~uz
z=W2L)ezr9)JA%>tdyn)?;0^g%<>ov=*Ryg}(n9_Ak*R+uL;Sh^ki%nrV<NM1ZOglV
zZ&uFKfklr$yE}ujdKKeua?W2u-DJ~OAYU&6Z_?P$JZ26j8Zav}BQCCvG8OT<-POq=
zWeI8n8PHYZlrf)PoX~IB3i{2ZpPeFAra^a=?7J3%qO*9}q18rdFv5F3hcYuQ`f1}5
zSM9BNQb>m{N7xrN-B%Cj#d1BF6<Mr*G=6H5p}WFoIoc1j>%fU-0ljdCP_NCuXs>eT
zN`-_5z^8>vGzDS{cKNJ{)*YeuFS(jNWz9ZE1p2{``V}z#x^-91r}(aip~9a%K%|l|
z#&>PT#nj1(Lk5~M1oUnwapjys;;&4o=0*P!n*8i1gQqw{P*f(%b4@!@BZP!Gr~}`B
z4;$9u<U~nQ;c~?RKPoY_hgg?ycT~ot+iJi31Prn5j*OUScY4nvQ9t{PE-jHfW3`_C
z0ke5Ds3Z>SZj@JZZGTfE3jhFBE|V`=I0m(eN6JGplkim>lZja%0jiU#Sz!TslMGs4
t0l$-MT3Z3<lgL_T0dA8oTW13GMw8%16qBr5P676l`&&i^yi@=H003taz#;$u
diff --git a/dta/privacy/provider.php b/dta/privacy/provider.php
index 13dfa1a..4a32e5a 100644
--- a/dta/privacy/provider.php
+++ b/dta/privacy/provider.php
@@ -23,20 +23,17 @@
*/
namespace assignsubmission_dta\privacy;
-defined('MOODLE_INTERNAL') || die();
-
-use \core_privacy\local\metadata\collection;
-use \core_privacy\local\request\writer;
-use \core_privacy\local\request\contextlist;
-use \mod_assign\privacy\assign_plugin_request_data;
+use core_privacy\local\metadata\collection;
+use core_privacy\local\request\writer;
+use core_privacy\local\request\contextlist;
+use mod_assign\privacy\assign_plugin_request_data;
class provider implements
// This plugin does store personal user data.
\core_privacy\local\metadata\provider,
\core_privacy\local\request\data_provider,
\mod_assign\privacy\assignsubmission_provider,
- \mod_assign\privacy\assignsubmission_user_provider
- {
+ \mod_assign\privacy\assignsubmission_user_provider {
/**
* File area for dta submission assignment.
@@ -49,7 +46,7 @@ class provider implements
[],
'privacy:metadata:core_files'
);
-
+
$collection->add_database_table(
'assignsubmission_dta_summary',
[
@@ -81,12 +78,12 @@ class provider implements
],
'privacy:metadata:assignsubmission_dta_result'
);
-
+
$collection->add_external_location_link('dta_backend', [
'assignmentid' => 'privacy:metadata:assignsubmission_dta_result:assignmentid',
'submissionid' => 'privacy:metadata:assignsubmission_dta_result:submissionid',
'submissioncontent' => 'privacy:metadata:core_files',
- ],
+ ],
'privacy:metadata:dta_backend'
);
@@ -140,11 +137,11 @@ class provider implements
$files = get_files($submission, $user);
foreach ($files as $file) {
$userid = $exportdata->get_pluginobject()->userid;
- $dtaresultsummary=DBUtils::getresultsummaryfromdatabase($assign->id, $submission->id);
+ $dtaresultsummary = DBUtils::getresultsummaryfromdatabase($assign->id, $submission->id);
// Submitted file.
writer::with_context($exportdata->get_context())->export_file($exportdata->get_subcontext(), $file)
// DTA result.
- ->export_related_data($dtaresultsummary);
+ ->export_related_data($dtaresultsummary);
// Plagiarism data.
$coursecontext = $context->get_course_context();
@@ -152,7 +149,7 @@ class provider implements
'cmid' => $context->instanceid,
'course' => $coursecontext->instanceid,
'userid' => $userid,
- 'file' => $file
+ 'file' => $file,
]);
}
}
@@ -171,7 +168,7 @@ class provider implements
$fs->delete_area_files($requestdata->get_context()->id, 'assignsubmission_dta', ASSIGNSUBMISSION_DTA_FILEAREA_SUBMISSION);
$assignmentid = $requestdata->get_assign()->get_instance()->id;
-
+
// Delete records from assignsubmission_dta tables.
$DB->delete_records('assignsubmission_dta_result', ['assignmentid' => $assignmentid]);
$DB->delete_records('assignsubmission_dta_summary', ['assignmentid' => $assignmentid]);
@@ -196,15 +193,15 @@ class provider implements
// Delete records from assignsubmission_dta tables. Also possible with a list as below.
$DB->delete_records('assignsubmission_dta_result', [
- 'assignmentid' => $assignmentid,
+ 'assignmentid' => $assignmentid,
'submissionid' => $submissionid,
]);
$DB->delete_records('assignsubmission_dta_summary', [
- 'assignmentid' => $assignmentid,
+ 'assignmentid' => $assignmentid,
'submissionid' => $submissionid,
]);
}
-
+
/**
* Deletes all submissions for the submission ids / userids provided in a context.
* assign_plugin_request_data contains:
@@ -240,7 +237,7 @@ class provider implements
* @return array - return an array of files indexed by filename
*/
public function get_files(stdClass $submission, stdClass $user) {
- $result = array();
+ $result = [];
$fs = get_file_storage();
$files = $fs->get_area_files($this->assignment->get_context()->id,
@@ -261,5 +258,4 @@ class provider implements
return $result;
}
-
-}
\ No newline at end of file
+}
--
GitLab