co2ampel issueshttps://transfer.hft-stuttgart.de/gitlab/groups/co2ampel/-/issues2021-06-07T08:04:19Zhttps://transfer.hft-stuttgart.de/gitlab/co2ampel/ampel-firmware/-/issues/3Calibration / reset interplay2021-06-07T08:04:19ZKäpplerCalibration / reset interplayI'm sorry for apparently breaking the forced calibration with commit
fe0234280e1160ce35914d02293182f94fb09e04.
While investigating, I found an interesting behaviour of the SCD30
that I would like to share / discuss.
It seems the breakage...I'm sorry for apparently breaking the forced calibration with commit
fe0234280e1160ce35914d02293182f94fb09e04.
While investigating, I found an interesting behaviour of the SCD30
that I would like to share / discuss.
It seems the breakage causes from the fact that the calibration value is not stored,
if the sensor is reset before carrying out at least one measurement after calibration.
The [interface datasheet](https://www.sensirion.com/fileadmin/user_upload/customers/sensirion/Dokumente/9.5_CO2/Sensirion_CO2_Sensors_SCD30_Interface_Description.pdf) has an interesting note:
> After soft reset the sensor will reload all calibrated data. However, it is worth noting that the sensor reloads calibration data prior to every measurement by default. This includes previously set reference values from ASC or FRC as well as temperature offset values last setting
However, the exact meaning of this paragraph is ambiguous and I'm not sure if it is related to the
mentioned issue.
You can reproduce the behaviour from the branch [dev/debugcalib](https://transfer.hft-stuttgart.de/gitlab/michael_kaeppler/ampel-firmware/-/tree/dev/debugcalib) in my fork. There I added an additional command `resetscd` to the serial console
and deactivated the automatic ESP reset after calibration.
Then do:
```
timer 10
calibrate! 1200
resetscd
```
-> The sensor does output a value based on the previous stored calibration.
If you try
```
timer 10
calibrate! 1200
```
(wait for a measurement)
```
resetscd
```
-> the sensor does output 1200 ppmhttps://transfer.hft-stuttgart.de/gitlab/co2ampel/ampel-firmware/-/issues/2Clean up repository structure2021-05-10T10:03:17ZKäpplerClean up repository structureThe Ampel sourcecode currently lives in a subdirectory `ampel-firmware`, which means that
after cloning the repo the path to the code files is e.g.
`ampel-firmware/ampel-firmware/foo.cpp`
and for the libraries
`ampel-firmware/ampel-f...The Ampel sourcecode currently lives in a subdirectory `ampel-firmware`, which means that
after cloning the repo the path to the code files is e.g.
`ampel-firmware/ampel-firmware/foo.cpp`
and for the libraries
`ampel-firmware/ampel-firmware/src/lib/*`
Is there a reason for this complicated structure?
I would propose to have the main source code in
`ampel-firmware/src/`
and the libs in
`ampel-firmware/src/lib/`
instead.https://transfer.hft-stuttgart.de/gitlab/co2ampel/ampel-documentation/-/issues/6Provide documentation as human-readable/editable file2021-04-01T06:48:09ZKäpplerProvide documentation as human-readable/editable fileHaving the documentation as PDF does not allow contributors to propose
changes directly. I would suggest to use Markdown instead.Having the documentation as PDF does not allow contributors to propose
changes directly. I would suggest to use Markdown instead.https://transfer.hft-stuttgart.de/gitlab/co2ampel/ampel-documentation/-/issues/5Merge repo 'ampel-documentation' into 'ampel-firmware'2021-04-01T06:45:39ZKäpplerMerge repo 'ampel-documentation' into 'ampel-firmware'Keeping them as two separate repositories does not make
much sense, IMHO. Users that do not want to touch the
code and simply need a manual will use the "released" documentation
in [https://www.hft-stuttgart.de/fileadmin/Dateien/Forschun...Keeping them as two separate repositories does not make
much sense, IMHO. Users that do not want to touch the
code and simply need a manual will use the "released" documentation
in [https://www.hft-stuttgart.de/fileadmin/Dateien/Forschung/Downloads/Bauanleitung-CO2-Ampel.pdf](https://www.hft-stuttgart.de/fileadmin/Dateien/Forschung/Downloads/Bauanleitung-CO2-Ampel.pdf), anyway.
For other cases where some code change in `ampel-firmware` involves some
change of functionality that has to be documented, it does make more sense
to have the repos together and have the corresponding changes in one MR or
even in one commit.https://transfer.hft-stuttgart.de/gitlab/co2ampel/ampel-documentation/-/issues/4Indicate threads in case drawing2021-03-31T20:32:59ZKäpplerIndicate threads in case drawingWould be good to indicate the threads that have to be cut into the backplate.Would be good to indicate the threads that have to be cut into the backplate.https://transfer.hft-stuttgart.de/gitlab/co2ampel/ampel-documentation/-/issues/3Mention thickness of case material2021-03-31T20:30:29ZKäpplerMention thickness of case materialIt would be nice to have the thickness of the raw case material
mentioned somewhere. One can infer it to 4 mm from the drawings,
but better mention it explicitly in the part list.
Maybe also add a note that cast acrylic glass does work...It would be nice to have the thickness of the raw case material
mentioned somewhere. One can infer it to 4 mm from the drawings,
but better mention it explicitly in the part list.
Maybe also add a note that cast acrylic glass does work better
for laser cutting than extruded material.https://transfer.hft-stuttgart.de/gitlab/co2ampel/ampel-documentation/-/issues/2Superfluous line in case drawing2021-03-31T20:25:57ZKäpplerSuperfluous line in case drawingThe file `CAD_CO2_Ampel_ohne_Bemassung.pdf` has a double line that
can cause issues during laser cutting, because the line will be cut twice.
![image](/uploads/8ee642c7d082644ffcb3a2e369e3f8b3/image.png)The file `CAD_CO2_Ampel_ohne_Bemassung.pdf` has a double line that
can cause issues during laser cutting, because the line will be cut twice.
![image](/uploads/8ee642c7d082644ffcb3a2e369e3f8b3/image.png)https://transfer.hft-stuttgart.de/gitlab/co2ampel/ampel-documentation/-/issues/1'400 Bad request' when trying to access subdir 'Case Drawings'2021-03-31T20:20:06ZKäppler'400 Bad request' when trying to access subdir 'Case Drawings'When trying to access files in subdir `Case Drawings`, GitLab does respond with
`400 Bad request`.When trying to access files in subdir `Case Drawings`, GitLab does respond with
`400 Bad request`.