From 99103b53928fc153d58d71bcb5a5f5feecdc68ba Mon Sep 17 00:00:00 2001
From: Eric Duminil <eric.duminil@gmail.com>
Date: Mon, 10 Oct 2022 10:02:18 +0200
Subject: [PATCH] Notes and warnings.
---
.../java/eu/simstadt/regionchooser/RegionExtractor.java | 8 +++++++-
.../regionchooser/website/script/simstadt_openlayers.js | 8 ++++----
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/main/java/eu/simstadt/regionchooser/RegionExtractor.java b/src/main/java/eu/simstadt/regionchooser/RegionExtractor.java
index e788939..39a1ec5 100644
--- a/src/main/java/eu/simstadt/regionchooser/RegionExtractor.java
+++ b/src/main/java/eu/simstadt/regionchooser/RegionExtractor.java
@@ -48,6 +48,9 @@
static StringBuilder selectRegionDirectlyFromCityGML(String wktPolygon, String srsName, Path... citygmlPaths)
throws ParseException, XPathParseException, NavException, IOException {
+ //TODO: Should actually write directly to a bufferedwriter
+ //TODO: Should return the number of found buildings.
+
int buildingsCount = 0;
int foundBuildingsCount = 0;
StringBuilder sb = new StringBuilder();
@@ -75,13 +78,16 @@ static StringBuilder selectRegionDirectlyFromCityGML(String wktPolygon, String s
LOGGER.info("1000 buildings parsed");
}
}
-
}
if (citygml == null) {
throw new IllegalArgumentException("There should be at least one citygml");
}
+ if (foundBuildingsCount == 0) {
+ LOGGER.warning("No building found in the selected region.");
+ }
+
LOGGER.info("Buildings found in selected region " + foundBuildingsCount);
sb.append(citygml.getFooter());
return sb;
diff --git a/src/main/resources/eu/simstadt/regionchooser/website/script/simstadt_openlayers.js b/src/main/resources/eu/simstadt/regionchooser/website/script/simstadt_openlayers.js
index b2e77da..2ffc457 100644
--- a/src/main/resources/eu/simstadt/regionchooser/website/script/simstadt_openlayers.js
+++ b/src/main/resources/eu/simstadt/regionchooser/website/script/simstadt_openlayers.js
@@ -69,7 +69,7 @@ var regionChooser = (function(){
dataPanel.append('.');
srsName = feature.get("srsName");
if (proj4.defs(srsName) === undefined){
- console.warning(srsName + " isn't defined by Proj4js!")
+ console.warn(srsName + " isn't defined by Proj4js!")
}
};
@@ -246,7 +246,7 @@ var regionChooser = (function(){
fxapp.downloadRegionFromCityGMLs(sketchAsWKT(srsName), project, citygmlNames.join(";"), srsName);
dataPanel.prepend("<h2 class='ok'>Done!</h2><br/>\n");
} catch (e) {
- console.warning("ERROR : " + e);
+ console.warn("ERROR : " + e);
dataPanel.prepend("<h2 class='error'>Some problem occured!</h2><br/>\n");
}
var end = new Date().getTime();
@@ -327,7 +327,7 @@ var regionChooser = (function(){
fxapp.log(message);
}
- console.warning = function(message){
+ console.warn = function(message){
fxapp.warning(message);
}
}
@@ -411,7 +411,7 @@ var regionChooser = (function(){
return;
}
catch (ex) {
- console.warning("Copy to clipboard failed.", ex);
+ console.warn("Copy to clipboard failed.", ex);
return prompt("Copy to clipboard: Ctrl+C, Enter", text);
}
finally {
--
GitLab