From 3b20982cc47b979efbad915af63e6db93e1ed4ab Mon Sep 17 00:00:00 2001 From: Eric Duminil <eric.duminil@gmail.com> Date: Fri, 25 Dec 2020 01:48:10 +0100 Subject: [PATCH] Different conventions for LEDs --- led_effects.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/led_effects.cpp b/led_effects.cpp index 3804ee1..e8523cb 100644 --- a/led_effects.cpp +++ b/led_effects.cpp @@ -43,11 +43,20 @@ namespace LedEffects { } void onBoardLEDOff() { + //NOTE: OFF is LOW on ESP32 and HIGH on ESP8266 :-/ +#ifdef ESP8266 digitalWrite(ONBOARD_LED_PIN, HIGH); +#else + digitalWrite(ONBOARD_LED_PIN, LOW); +#endif } void onBoardLEDOn() { +#ifdef ESP8266 digitalWrite(ONBOARD_LED_PIN, LOW); +#else + digitalWrite(ONBOARD_LED_PIN, HIGH); +#endif } void LEDsOff() { -- GitLab