From 96d095f8d83b59fe0deadee23e5c906350dc2e71 Mon Sep 17 00:00:00 2001
From: Eric Duminil <eric.duminil@gmail.com>
Date: Fri, 8 Jan 2021 23:48:25 +0100
Subject: [PATCH] FIXME: use millis for durations, not timestamps
---
ampel-firmware/led_effects.cpp | 1 +
ampel-firmware/lorawan.cpp | 1 +
2 files changed, 2 insertions(+)
diff --git a/ampel-firmware/led_effects.cpp b/ampel-firmware/led_effects.cpp
index 1410a14..af463f6 100644
--- a/ampel-firmware/led_effects.cpp
+++ b/ampel-firmware/led_effects.cpp
@@ -146,6 +146,7 @@ namespace led_effects {
static uint16_t wheel_offset = 0;
unsigned long t0 = millis();
pixels.setBrightness(config::max_brightness);
+ //FIXME: OVERFLOW!
while (millis() < t0 + duration_ms) {
for (int i = 0; i < NUMPIXELS; i++) {
pixels.setPixelColor(i, pixels.ColorHSV(i * 65535 / NUMPIXELS + wheel_offset));
diff --git a/ampel-firmware/lorawan.cpp b/ampel-firmware/lorawan.cpp
index 75363a0..e9f8058 100644
--- a/ampel-firmware/lorawan.cpp
+++ b/ampel-firmware/lorawan.cpp
@@ -184,6 +184,7 @@ namespace lorawan {
void preparePayloadIfTimeHasCome(const int16_t &co2, const float &temperature, const float &humidity) {
static unsigned long last_sent_at = 0;
unsigned long now = seconds();
+ //FIXME: OVERFLOW!
if (connected && (now > last_sent_at + config::lorawan_sending_interval)) {
last_sent_at = now;
preparePayload(co2, temperature, humidity);
--
GitLab