Notes

ampel-firmware/ntp.cpp

@@ -19,7 +19,7 @@ namespace ntp {
     Serial.print("NTP - Trying to connect to : ");
     Serial.println(config::ntp_server);
     timeClient.begin();
-    sensor_console::defineIntCommand("set_time", ntp::setLocalTime, F("1618829570 (Sets time to the given UNIX time)"));
+    sensor_console::defineIntCommand("set_time", ntp::setLocalTime, F("1618829570 (Sets time to the given UNIX time)")); //TODO: Define even without internet
   }
 
   void update() {

ampel-firmware/web_config.h

 #ifndef AMPEL_WEB_CONFIG_H_
 #define AMPEL_WEB_CONFIG_H_
 
-#define STRING_LEN 64
+#define STRING_LEN 64 //TODO: Shorter?
 
 #if defined(ESP8266)
 #  include <ESP8266WebServer.h>
@@ -32,7 +32,7 @@ namespace config {
   extern bool &daylight_saving_time; // [true / false]
 
   //CSV
-  bool csv_active();
+  bool csv_active(); //TODO: Find better names?
   extern uint16_t &csv_interval; // [s]
 
   // MQTT
@@ -56,7 +56,6 @@ namespace web_config {
   void setWifiConnectionCallback(void (*success_function)());
   void setWifiFailCallback(void (*fail_function)());
   void update();
-  //TODO: Add saveConfig(), for e.g. after custom setters. Or simply reset after each configchange?
 
 #if defined(ESP8266)
   extern ESP8266WebServer http;

ampel-firmware/web_server.cpp

@@ -11,9 +11,6 @@
 #include "mqtt.h"
 #include "lorawan.h"
 
-#include <IotWebConf.h>
-#include <IotWebConfUsing.h> // This loads aliases for easier class names.
-#include <IotWebConfTParameter.h>
 #if defined(ESP8266)
 #  include <ESP8266WebServer.h>
 #elif defined(ESP32)