Notes

ampel-firmware/ampel-firmware.ino

@@ -76,7 +76,6 @@ void setup() {
   Serial.println(BOARD);
 
 #ifdef AMPEL_WIFI
-  // Try to connect to Wi-Fi
   WiFiConnect(SENSOR_ID);
 
   Serial.print(F("WiFi STATUS: "));
@@ -126,7 +125,7 @@ void loop() {
   }
 #endif
   //NOTE: Loop should never take more than 1000ms. Split in smaller methods and logic if needed.
-  //TODO: Restart every day or week, in order to not let t0 overflow?
+  //NOTE: Only use millis() for duration comparison, not timestamps comparison. Otherwise, problems happen when millis roll over.
   uint32_t t0 = millis();
 
   keepServicesAlive();

ampel-firmware/util.h

@@ -36,6 +36,7 @@ namespace util {
   }
 }
 
+//NOTE: Only use seconds() for duration comparison, not timestamps comparison. Otherwise, problems happen when millis roll over.
 #define seconds() (millis() / 1000UL)
 extern uint32_t max_loop_duration;
 const extern String SENSOR_ID;