ampel-firmware/co2_sensor.cpp

@@ -33,7 +33,6 @@ namespace sensor {
    * INITIAL -> initial state
    * BOOTUP -> state after initializing the sensor, i.e. after scd.begin()
    * READY -> sensor does output valid information (> 0 ppm) and no other condition takes place
-   * INVALID -> sensor does output invalid CO2 measurements (== 0 ppm)
    * NEEDS_CALIBRATION -> sensor measurements are too low (< 250 ppm)
    * PREPARE_CALIBRATION -> forced calibration was initiated, waiting for stable measurements
    */
@@ -41,7 +40,6 @@ namespace sensor {
     INITIAL,
     BOOTUP,
     READY,
-    INVALID,
     NEEDS_CALIBRATION,
     PREPARE_CALIBRATION_UNSTABLE,
     PREPARE_CALIBRATION_STABLE
@@ -50,7 +48,6 @@ namespace sensor {
       "INITIAL",
       "BOOTUP",
       "READY",
-      "INVALID",
       "NEEDS_CALIBRATION",
       "PREPARE_CALIBRATION_UNSTABLE",
       "PREPARE_CALIBRATION_STABLE" };
@@ -80,9 +77,10 @@ namespace sensor {
       ESP.restart();
     }
 
-    // Sometimes after a hard reset of the ESP the SCD30 needs
-    // a long time until returning the first measurement. Resetting it
-    // after startup seems to fix this behaviour.
+    // Changes of the SCD30's measurement timestep do not come into effect
+    // before the next measurement takes place. That means that after a hard reset
+    // of the ESP the SCD30 sometimes needs a long time until switching back to 2 s
+    // for acclimatization. Resetting it after startup seems to fix this behaviour.
     scd30.reset();
     switchState(BOOTUP);
 
@@ -209,12 +207,7 @@ namespace sensor {
       Serial.println(" s.");
       scd30.setMeasurementInterval(config::measurement_timestep); // [s]
     }
-    if (co2 == 0) {
-      // NOTE: Data is available, but it's sometimes erroneous: the sensor outputs
-      // zero ppm but non-zero temperature and non-zero humidity.
-      Serial.println(F("Invalid sensor data - CO2 concentration supposedly 0 ppm"));
-      switchState(INVALID);
-    } else if ((current_state == PREPARE_CALIBRATION_UNSTABLE) || (current_state == PREPARE_CALIBRATION_STABLE)) {
+    if ((current_state == PREPARE_CALIBRATION_UNSTABLE) || (current_state == PREPARE_CALIBRATION_STABLE)) {
       // Check for pre-calibration states first, because we do not want to
       // leave them before calibration is done.
       bool ready_for_calibration = countStableMeasurements();
@@ -252,9 +245,6 @@ namespace sensor {
     case READY:
       displayCO2OnLedRing();
       break;
-    case INVALID:
-      led_effects::showWaitingLED(color::red);
-      break;
     case NEEDS_CALIBRATION:
       led_effects::showWaitingLED(color::magenta);
       break;
@@ -290,7 +280,9 @@ namespace sensor {
 
     showState();
 
-    return freshData;
+    // Report data for further processing only if the data is reliable
+    // (state 'READY') or manual calibration is necessary (state 'NEEDS_CALIBRATION').
+    return freshData && (current_state == READY || current_state == NEEDS_CALIBRATION);
   }
 
   /*****************************************************************