Verified Commit 1e4434ab authored by Lukas Wiest's avatar Lukas Wiest :steam_locomotive:
Browse files

refactor(core/TicketBuilder): make assignees setter non abstract and use string

No related merge requests found
Pipeline #1247 passed with stages
in 2 minutes and 28 seconds
Showing with 16 additions and 12 deletions
+16 -12
...@@ -20,7 +20,7 @@ public abstract class TicketBuilder<B extends TicketBuilder, T extends Ticket, T ...@@ -20,7 +20,7 @@ public abstract class TicketBuilder<B extends TicketBuilder, T extends Ticket, T
public final TS parent; public final TS parent;
protected Set<Integer> assignees; protected Set<String> assignees;
protected String description; protected String description;
protected Set<String> labels; protected Set<String> labels;
protected String title; protected String title;
...@@ -37,7 +37,11 @@ public abstract class TicketBuilder<B extends TicketBuilder, T extends Ticket, T ...@@ -37,7 +37,11 @@ public abstract class TicketBuilder<B extends TicketBuilder, T extends Ticket, T
logger.log(Level.FINEST, String.format("%s instantiated", this.getClass().getSimpleName())); logger.log(Level.FINEST, String.format("%s instantiated", this.getClass().getSimpleName()));
} }
public abstract B assignees(String... identifiers); public B assignees(String... identifiers)
{
this.assignees = new HashSet<>(Arrays.asList(identifiers));
return (B) this;
}
public B description(String description) public B description(String description)
{ {
......
...@@ -29,12 +29,10 @@ public class GitlabTicketBuilder extends TicketBuilder<GitlabTicketBuilder, Gitl ...@@ -29,12 +29,10 @@ public class GitlabTicketBuilder extends TicketBuilder<GitlabTicketBuilder, Gitl
@Override @Override
public GitlabTicketBuilder assignees(String... identifiers) public GitlabTicketBuilder assignees(String... identifiers)
{ {
try try
{ {
assignees(Arrays.stream(identifiers) Arrays.stream(identifiers)
.mapToInt(Integer::parseInt) .forEach(Integer::parseInt);
.toArray());
} catch (NumberFormatException e) } catch (NumberFormatException e)
{ {
...@@ -42,15 +40,14 @@ public class GitlabTicketBuilder extends TicketBuilder<GitlabTicketBuilder, Gitl ...@@ -42,15 +40,14 @@ public class GitlabTicketBuilder extends TicketBuilder<GitlabTicketBuilder, Gitl
throw new AssertionException(e); throw new AssertionException(e);
} }
return this; return super.assignees(identifiers);
} }
public GitlabTicketBuilder assignees(int... identifiers) public GitlabTicketBuilder assignees(int... identifiers)
{ {
assignees = Arrays.stream(identifiers) return super.assignees(Arrays.stream(identifiers)
.mapToObj(i -> (Integer) i) .mapToObj(String::valueOf)
.collect(Collectors.toSet()); .toArray(String[]::new));
return this;
} }
protected OkHttpClient getHttpClient() { return new OkHttpClient(); } protected OkHttpClient getHttpClient() { return new OkHttpClient(); }
...@@ -83,7 +80,10 @@ public class GitlabTicketBuilder extends TicketBuilder<GitlabTicketBuilder, Gitl ...@@ -83,7 +80,10 @@ public class GitlabTicketBuilder extends TicketBuilder<GitlabTicketBuilder, Gitl
if (this.assignees != null) if (this.assignees != null)
{ {
ArrayNode ids = body.putArray("assignee_ids"); ArrayNode ids = body.putArray("assignee_ids");
assignees.forEach(ids::add); assignees
.stream()
.mapToInt(Integer::parseInt)
.forEach(ids::add);
logger.log(Level.FINEST, "assignees set"); logger.log(Level.FINEST, "assignees set");
} }
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment