Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • ampel-firmware ampel-firmware
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • co2ampelco2ampel
  • ampel-firmwareampel-firmware
  • Merge requests
  • !10

Do not check flash button during calibration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Käppler requested to merge michael_kaeppler/ampel-firmware:dev/calibnightmode into develop Jun 07, 2021
  • Overview 9
  • Commits 3
  • Pipelines 2
  • Changes 5

After pressing the "Flash" button a long time to initiate calibration and releasing it after the finished countdown, the ampel sometimes switches to night mode.

This happens if the button is still pressed during the next call of checkFlashButton() and released < 300 ms after that.

Therefore:

  • Disable button polling during calibration.
  • Clarify blocking nature of led_effects::countdownToZero()

I was pretty confused how checkFlashButton() and countdownToZero interact and think that it is clearer now. I know there is a 'loss' of functionality in the sense that it is not possible to check for partially-finished countdowns. But this functionality was not used.

Closes #4 (closed).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev/calibnightmode

Dies ist die Gitlab-Instanz des Transferportals der Hochschule für Technik Stuttgart. Hier geht es zurück zum Portal