Coding style and recommendations

The branch includes Niklas changes to show the correct recommendations after an assignment submission and changes the code style and naming to the moodle standard requirements.

dta/privacy/provider.php

@@ -23,20 +23,17 @@
  */
 namespace assignsubmission_dta\privacy;
 
-defined('MOODLE_INTERNAL') || die();
-
-use \core_privacy\local\metadata\collection;
-use \core_privacy\local\request\writer;
-use \core_privacy\local\request\contextlist;
-use \mod_assign\privacy\assign_plugin_request_data;
+use core_privacy\local\metadata\collection;
+use core_privacy\local\request\writer;
+use core_privacy\local\request\contextlist;
+use mod_assign\privacy\assign_plugin_request_data;
 
 class provider implements
         // This plugin does store personal user data.
         \core_privacy\local\metadata\provider,
         \core_privacy\local\request\data_provider,
         \mod_assign\privacy\assignsubmission_provider,
-        \mod_assign\privacy\assignsubmission_user_provider
-        {
+        \mod_assign\privacy\assignsubmission_user_provider {
 
     /**
      * File area for dta submission assignment.
@@ -49,7 +46,7 @@ class provider implements
             [],
             'privacy:metadata:core_files'
         );
-        
+
         $collection->add_database_table(
             'assignsubmission_dta_summary',
             [
@@ -81,12 +78,12 @@ class provider implements
             ],
             'privacy:metadata:assignsubmission_dta_result'
         );
-        
+
         $collection->add_external_location_link('dta_backend', [
                 'assignmentid' => 'privacy:metadata:assignsubmission_dta_result:assignmentid',
                 'submissionid' => 'privacy:metadata:assignsubmission_dta_result:submissionid',
                 'submissioncontent' => 'privacy:metadata:core_files',
-            ], 
+            ],
             'privacy:metadata:dta_backend'
         );
 
@@ -140,11 +137,11 @@ class provider implements
         $files = get_files($submission, $user);
         foreach ($files as $file) {
             $userid = $exportdata->get_pluginobject()->userid;
-            $dtaresultsummary=DBUtils::getresultsummaryfromdatabase($assign->id, $submission->id);
+            $dtaresultsummary = DBUtils::getresultsummaryfromdatabase($assign->id, $submission->id);
             // Submitted file.
             writer::with_context($exportdata->get_context())->export_file($exportdata->get_subcontext(), $file)
             // DTA result.
-            ->export_related_data($dtaresultsummary);             
+            ->export_related_data($dtaresultsummary);
 
             // Plagiarism data.
             $coursecontext = $context->get_course_context();
@@ -152,7 +149,7 @@ class provider implements
                 'cmid' => $context->instanceid,
                 'course' => $coursecontext->instanceid,
                 'userid' => $userid,
-                'file' => $file
+                'file' => $file,
             ]);
         }
     }
@@ -171,7 +168,7 @@ class provider implements
         $fs->delete_area_files($requestdata->get_context()->id, 'assignsubmission_dta', ASSIGNSUBMISSION_DTA_FILEAREA_SUBMISSION);
 
         $assignmentid = $requestdata->get_assign()->get_instance()->id;
-                
+
         // Delete records from assignsubmission_dta tables.
         $DB->delete_records('assignsubmission_dta_result', ['assignmentid' => $assignmentid]);
         $DB->delete_records('assignsubmission_dta_summary', ['assignmentid' => $assignmentid]);
@@ -196,15 +193,15 @@ class provider implements
 
         // Delete records from assignsubmission_dta tables. Also possible with a list as below.
         $DB->delete_records('assignsubmission_dta_result', [
-            'assignmentid' => $assignmentid, 
+            'assignmentid' => $assignmentid,
             'submissionid' => $submissionid,
             ]);
         $DB->delete_records('assignsubmission_dta_summary', [
-            'assignmentid' => $assignmentid, 
+            'assignmentid' => $assignmentid,
             'submissionid' => $submissionid,
             ]);
     }
-    
+
     /**
      * Deletes all submissions for the submission ids / userids provided in a context.
      * assign_plugin_request_data contains:
@@ -240,7 +237,7 @@ class provider implements
      * @return array - return an array of files indexed by filename
      */
     public function get_files(stdClass $submission, stdClass $user) {
-        $result = array();
+        $result = [];
         $fs = get_file_storage();
 
         $files = $fs->get_area_files($this->assignment->get_context()->id,
@@ -261,5 +258,4 @@ class provider implements
         return $result;
     }
 
-
-}
\ No newline at end of file
+}