Coding style and recommendations

The branch includes Niklas changes to show the correct recommendations after an assignment submission and changes the code style and naming to the moodle standard requirements.

dta/classes/dta_view_submission_utils.php

@@ -102,7 +102,7 @@ class dta_view_submission_utils {
         // If there are failed tests, show them.
         if ($failcount > 0) {
             $html .= $failcount
-                  . get_string('tests_failed', self::ASSIGNSUBMISSION_DTA_COMPONENT_NAME)
+                  . get_string('failures', self::ASSIGNSUBMISSION_DTA_COMPONENT_NAME)
                   . "<br />";
         }
 

dta/lang/en/assignsubmission_dta.php

@@ -92,22 +92,22 @@ $string["comp14"] = $string["comp_simple"];
 $string["comp15"] = $string["comp_abstraction"];
 
 // Competency explanations.
-$string["comp_statement_expl"] = "formulate a syntactically correct statement that contributes to the solution of the given problem.";
-$string["comp_block_expl"] = "structure code into syntactically correct small unnamed units that contribute to the solution of the given problem.";
-$string["comp_flow_expl"] = "formulate syntax elements guiding the control flow such that it contributes to the solution of the given problem.";
-$string["comp_loop_expl"] = "use syntax elements repeating statements such that it contributes to the solution of the given problem.";
-$string["comp_const_expl"] = "identify and syntactically correctly define constants that contribute to the understanding and solution of the given problem.";
-$string["comp_var_expl"] = "identify and syntactically correctly define variables that contribute to the solution of the given problem.";
-$string["comp_type_expl"] = "define and/or choose appropriate data types for data elements such that they contribute to the solution of the given problem.";
-$string["comp_datastructure_expl"] = "define and/or choose appropriate data structures for data elements such that they contribute to the solution of the given problem.";
-$string["comp_interface_expl"] = "define and use interfaces for larger units of code such that it contributes to the solution of the given problem.";
-$string["comp_unit_expl"] = "define and larger units of code such that it contributes to the solution of the given problem.";
-$string["comp_proc_usage_expl"] = "use existing named structure blocks with a pre-defined behavior and signature such that it contributes to the solution of the given problem.";
-$string["comp_proc_sign_expl"] = "define named structure blocks with a pre-defined behavior and signature such that it contributes to the solution of the given problem.";
-$string["comp_library_expl"] = "use existing larger collections of named structure blocks with a pre-defined behavior and signature such that it contributes to the solution of the given problem.";
-$string["comp_ext_api_expl"] = "use standardized existing external collections of named structure blocks with a pre-defined behavior and signature such that it contributes to the solution of the given problem.";
-$string["comp_simple_expl"] = "create a simple solution of the given problem.";
-$string["comp_abstraction_expl"] = "create a sufficiently abstract solution for the given problem.";
+$string["comp_statement_expl"] = "Formulate a syntactically correct statement that contributes to the solution of the given problem.";
+$string["comp_block_expl"] = "Structure code into syntactically correct small unnamed units that contribute to the solution of the given problem.";
+$string["comp_flow_expl"] = "Formulate syntax elements guiding the control flow such that it contributes to the solution of the given problem.";
+$string["comp_loop_expl"] = "Use syntax elements repeating statements such that it contributes to the solution of the given problem.";
+$string["comp_const_expl"] = "Identify and syntactically correctly define constants that contribute to the understanding and solution of the given problem.";
+$string["comp_var_expl"] = "Identify and syntactically correctly define variables that contribute to the solution of the given problem.";
+$string["comp_type_expl"] = "Define and/or choose appropriate data types for data elements such that they contribute to the solution of the given problem.";
+$string["comp_datastructure_expl"] = "Define and/or choose appropriate data structures for data elements such that they contribute to the solution of the given problem.";
+$string["comp_interface_expl"] = "Define and use interfaces for larger units of code such that it contributes to the solution of the given problem.";
+$string["comp_unit_expl"] = "Define and larger units of code such that it contributes to the solution of the given problem.";
+$string["comp_proc_usage_expl"] = "Use existing named structure blocks with a pre-defined behavior and signature such that it contributes to the solution of the given problem.";
+$string["comp_proc_sign_expl"] = "Define named structure blocks with a pre-defined behavior and signature such that it contributes to the solution of the given problem.";
+$string["comp_library_expl"] = "Use existing larger collections of named structure blocks with a pre-defined behavior and signature such that it contributes to the solution of the given problem.";
+$string["comp_ext_api_expl"] = "Use standardized existing external collections of named structure blocks with a pre-defined behavior and signature such that it contributes to the solution of the given problem.";
+$string["comp_simple_expl"] = "Create a simple solution of the given problem.";
+$string["comp_abstraction_expl"] = "Create a sufficiently abstract solution for the given problem.";
 
 // Competency explanations for index calculations.
 $string["comp_expl0"] = $string["comp_statement_expl"];