Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
CityDoctor
CityDoctor2
Commits
74cdade3
Commit
74cdade3
authored
May 14, 2025
by
Riegel
Browse files
Refactor: Rename AbstractCheck
parent
120466a0
Changes
31
Hide whitespace changes
Inline
Side-by-side
CityDoctorParent/CityDoctorModel/src/test/java/de/hft/stuttgart/citydoctor2/datastructure/GeometryTest.java
View file @
74cdade3
...
@@ -32,8 +32,8 @@ import static org.mockito.Mockito.when;
...
@@ -32,8 +32,8 @@ import static org.mockito.Mockito.when;
import
java.util.ArrayList
;
import
java.util.ArrayList
;
import
java.util.List
;
import
java.util.List
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.utils.visitors.Clear
Check
ResultsVisitor
;
import
de.hft.stuttgart.citydoctor2.utils.visitors.Clear
Visitor
ResultsVisitor
;
import
org.citygml4j.core.model.construction.AbstractConstructionSurface
;
import
org.citygml4j.core.model.construction.AbstractConstructionSurface
;
import
org.citygml4j.core.model.construction.WallSurface
;
import
org.citygml4j.core.model.construction.WallSurface
;
import
org.citygml4j.core.util.geometry.GeometryFactory
;
import
org.citygml4j.core.util.geometry.GeometryFactory
;
...
@@ -63,7 +63,7 @@ public class GeometryTest {
...
@@ -63,7 +63,7 @@ public class GeometryTest {
geom
.
addPolygon
(
mockPolygon
);
geom
.
addPolygon
(
mockPolygon
);
Abstract
Check
c
=
new
Abstract
Check
()
{
Abstract
Visitor
c
=
new
Abstract
Visitor
()
{
};
};
geom
.
accept
(
c
);
geom
.
accept
(
c
);
...
@@ -300,7 +300,7 @@ public class GeometryTest {
...
@@ -300,7 +300,7 @@ public class GeometryTest {
Polygon
p
=
mock
(
Polygon
.
class
);
Polygon
p
=
mock
(
Polygon
.
class
);
geom
.
addPolygon
(
p
);
geom
.
addPolygon
(
p
);
geom
.
clearAllContainedCheckResults
();
geom
.
clearAllContainedCheckResults
();
verify
(
p
).
accept
(
any
(
Clear
Check
ResultsVisitor
.
class
));
verify
(
p
).
accept
(
any
(
Clear
Visitor
ResultsVisitor
.
class
));
assertFalse
(
geom
.
containsError
(
CheckId
.
C_GE_P_HOLE_OUTSIDE
));
assertFalse
(
geom
.
containsError
(
CheckId
.
C_GE_P_HOLE_OUTSIDE
));
}
}
...
...
CityDoctorParent/CityDoctorModel/src/test/java/de/hft/stuttgart/citydoctor2/datastructure/ImplicitGeometryTest.java
View file @
74cdade3
package
de.hft.stuttgart.citydoctor2.datastructure
;
package
de.hft.stuttgart.citydoctor2.datastructure
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
...
@@ -150,7 +150,7 @@ public class ImplicitGeometryTest {
...
@@ -150,7 +150,7 @@ public class ImplicitGeometryTest {
AtomicInteger
loCounter
=
new
AtomicInteger
(
0
);
AtomicInteger
loCounter
=
new
AtomicInteger
(
0
);
Abstract
Check
c
=
new
Abstract
Check
()
{
Abstract
Visitor
c
=
new
Abstract
Visitor
()
{
@Override
@Override
public
void
check
(
Polygon
lo
)
{
public
void
check
(
Polygon
lo
)
{
loCounter
.
incrementAndGet
();
loCounter
.
incrementAndGet
();
...
...
CityDoctorParent/CityDoctorModel/src/test/java/de/hft/stuttgart/citydoctor2/datastructure/ReliefObjectTest.java
View file @
74cdade3
package
de.hft.stuttgart.citydoctor2.datastructure
;
package
de.hft.stuttgart.citydoctor2.datastructure
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
org.citygml4j.core.model.relief.ReliefFeature
;
import
org.citygml4j.core.model.relief.ReliefFeature
;
import
org.junit.Test
;
import
org.junit.Test
;
...
@@ -16,7 +16,7 @@ public class ReliefObjectTest {
...
@@ -16,7 +16,7 @@ public class ReliefObjectTest {
TinObject
mockTin
=
mock
(
TinObject
.
class
);
TinObject
mockTin
=
mock
(
TinObject
.
class
);
relief
.
addComponent
(
mockTin
);
relief
.
addComponent
(
mockTin
);
Abstract
Check
c
=
new
Abstract
Check
()
{
Abstract
Visitor
c
=
new
Abstract
Visitor
()
{
};
};
relief
.
accept
(
c
);
relief
.
accept
(
c
);
...
...
CityDoctorParent/CityDoctorModel/src/test/java/de/hft/stuttgart/citydoctor2/datastructure/TinObjectTest.java
View file @
74cdade3
package
de.hft.stuttgart.citydoctor2.datastructure
;
package
de.hft.stuttgart.citydoctor2.datastructure
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
...
@@ -32,7 +32,7 @@ public class TinObjectTest {
...
@@ -32,7 +32,7 @@ public class TinObjectTest {
tin
.
addGeometry
(
mockGeometry
);
tin
.
addGeometry
(
mockGeometry
);
Abstract
Check
c
=
new
Abstract
Check
()
{
Abstract
Visitor
c
=
new
Abstract
Visitor
()
{
};
};
tin
.
accept
(
c
);
tin
.
accept
(
c
);
...
...
CityDoctorParent/CityDoctorModel/src/test/java/de/hft/stuttgart/citydoctor2/datastructure/TopLevelTransportFeatureTest.java
View file @
74cdade3
package
de.hft.stuttgart.citydoctor2.datastructure
;
package
de.hft.stuttgart.citydoctor2.datastructure
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
...
@@ -54,7 +54,7 @@ public class TopLevelTransportFeatureTest {
...
@@ -54,7 +54,7 @@ public class TopLevelTransportFeatureTest {
top
.
addSection
(
mockSection
);
top
.
addSection
(
mockSection
);
top
.
addIntersection
(
mockIntersection
);
top
.
addIntersection
(
mockIntersection
);
Abstract
Check
c
=
new
Abstract
Check
()
{
Abstract
Visitor
c
=
new
Abstract
Visitor
()
{
};
};
top
.
accept
(
c
);
top
.
accept
(
c
);
...
...
CityDoctorParent/CityDoctorModel/src/test/java/de/hft/stuttgart/citydoctor2/datastructure/TrafficSpaceTest.java
View file @
74cdade3
package
de.hft.stuttgart.citydoctor2.datastructure
;
package
de.hft.stuttgart.citydoctor2.datastructure
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
import
de.hft.stuttgart.citydoctor2.check.ResultStatus
;
import
de.hft.stuttgart.citydoctor2.check.ResultStatus
;
import
de.hft.stuttgart.citydoctor2.parser.ParserConfiguration
;
import
de.hft.stuttgart.citydoctor2.parser.ParserConfiguration
;
import
de.hft.stuttgart.citydoctor2.utils.visitors.Clear
Check
ResultsVisitor
;
import
de.hft.stuttgart.citydoctor2.utils.visitors.Clear
Visitor
ResultsVisitor
;
import
org.citygml4j.core.model.core.AbstractSpaceBoundary
;
import
org.citygml4j.core.model.core.AbstractSpaceBoundary
;
import
org.citygml4j.core.model.core.AbstractUnoccupiedSpace
;
import
org.citygml4j.core.model.core.AbstractUnoccupiedSpace
;
import
org.citygml4j.core.model.deprecated.core.DeprecatedPropertiesOfAbstractCityObject
;
import
org.citygml4j.core.model.deprecated.core.DeprecatedPropertiesOfAbstractCityObject
;
...
@@ -37,7 +37,7 @@ public class TrafficSpaceTest {
...
@@ -37,7 +37,7 @@ public class TrafficSpaceTest {
TrafficAreaObject
areaMock
=
mock
(
TrafficAreaObject
.
class
);
TrafficAreaObject
areaMock
=
mock
(
TrafficAreaObject
.
class
);
tso
.
addTrafficArea
(
areaMock
);
tso
.
addTrafficArea
(
areaMock
);
Abstract
Check
c
=
new
Abstract
Check
()
{
Abstract
Visitor
c
=
new
Abstract
Visitor
()
{
};
};
tso
.
accept
(
c
);
tso
.
accept
(
c
);
...
@@ -91,7 +91,7 @@ public class TrafficSpaceTest {
...
@@ -91,7 +91,7 @@ public class TrafficSpaceTest {
tso
.
clearAllContainedCheckResults
();
tso
.
clearAllContainedCheckResults
();
assertFalse
(
tso
.
containsError
(
CheckId
.
C_GE_P_HOLE_OUTSIDE
));
assertFalse
(
tso
.
containsError
(
CheckId
.
C_GE_P_HOLE_OUTSIDE
));
verify
(
taMock
).
accept
(
any
(
Clear
Check
ResultsVisitor
.
class
));
verify
(
taMock
).
accept
(
any
(
Clear
Visitor
ResultsVisitor
.
class
));
}
}
@Test
@Test
...
...
CityDoctorParent/CityDoctorModel/src/test/java/de/hft/stuttgart/citydoctor2/datastructure/TransportationSpaceTest.java
View file @
74cdade3
package
de.hft.stuttgart.citydoctor2.datastructure
;
package
de.hft.stuttgart.citydoctor2.datastructure
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
...
@@ -32,7 +32,7 @@ public class TransportationSpaceTest {
...
@@ -32,7 +32,7 @@ public class TransportationSpaceTest {
space
.
addTrafficSpace
(
mockSpace
);
space
.
addTrafficSpace
(
mockSpace
);
space
.
addAuxTrafficSpace
(
auxMockSpace
);
space
.
addAuxTrafficSpace
(
auxMockSpace
);
Abstract
Check
c
=
new
Abstract
Check
()
{
Abstract
Visitor
c
=
new
Abstract
Visitor
()
{
};
};
space
.
accept
(
c
);
space
.
accept
(
c
);
...
...
CityDoctorParent/CityDoctorModel/src/test/java/de/hft/stuttgart/citydoctor2/datastructure/WaterTest.java
View file @
74cdade3
package
de.hft.stuttgart.citydoctor2.datastructure
;
package
de.hft.stuttgart.citydoctor2.datastructure
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckId
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
import
de.hft.stuttgart.citydoctor2.check.CheckResult
;
...
@@ -33,7 +33,7 @@ public class WaterTest {
...
@@ -33,7 +33,7 @@ public class WaterTest {
water
.
addBoundarySurface
(
bsMock
);
water
.
addBoundarySurface
(
bsMock
);
water
.
addBoundarySurface
(
bsMock2
);
water
.
addBoundarySurface
(
bsMock2
);
Abstract
Check
c
=
new
Abstract
Check
()
{
Abstract
Visitor
c
=
new
Abstract
Visitor
()
{
};
};
water
.
accept
(
c
);
water
.
accept
(
c
);
...
...
CityDoctorParent/Extensions/CityDoctorHealer/src/main/java/de/hft/stuttgart/citydoctor2/healer/Healer.java
View file @
74cdade3
...
@@ -26,7 +26,7 @@ import org.citygml4j.xml.writer.CityGMLWriteException;
...
@@ -26,7 +26,7 @@ import org.citygml4j.xml.writer.CityGMLWriteException;
import
org.citygml4j.xml.writer.CityGMLWriter
;
import
org.citygml4j.xml.writer.CityGMLWriter
;
import
de.hft.stuttgart.citydoctor2.CityDoctorValidation
;
import
de.hft.stuttgart.citydoctor2.CityDoctorValidation
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.Checker
;
import
de.hft.stuttgart.citydoctor2.check.Checker
;
import
de.hft.stuttgart.citydoctor2.check.HealingMethod
;
import
de.hft.stuttgart.citydoctor2.check.HealingMethod
;
...
@@ -353,7 +353,7 @@ public class Healer {
...
@@ -353,7 +353,7 @@ public class Healer {
private
void
filterOutDuplicateVertices
(
CityObject
co
)
{
private
void
filterOutDuplicateVertices
(
CityObject
co
)
{
Map
<
Vertex
,
Vertex
>
map
=
new
HashMap
<>();
Map
<
Vertex
,
Vertex
>
map
=
new
HashMap
<>();
co
.
accept
(
new
Abstract
Check
()
{
co
.
accept
(
new
Abstract
Visitor
()
{
@Override
@Override
public
void
check
(
LinearRing
ring
)
{
public
void
check
(
LinearRing
ring
)
{
for
(
int
i
=
0
;
i
<
ring
.
getVertices
().
size
();
i
++)
{
for
(
int
i
=
0
;
i
<
ring
.
getVertices
().
size
();
i
++)
{
...
...
CityDoctorParent/Extensions/CityDoctorHealer/src/main/java/de/hft/stuttgart/citydoctor2/healing/HealMissingSolid.java
View file @
74cdade3
...
@@ -24,7 +24,7 @@ import java.util.List;
...
@@ -24,7 +24,7 @@ import java.util.List;
import
org.apache.logging.log4j.LogManager
;
import
org.apache.logging.log4j.LogManager
;
import
org.apache.logging.log4j.Logger
;
import
org.apache.logging.log4j.Logger
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.check.HealingID
;
import
de.hft.stuttgart.citydoctor2.check.HealingID
;
import
de.hft.stuttgart.citydoctor2.check.HealingMethod
;
import
de.hft.stuttgart.citydoctor2.check.HealingMethod
;
import
de.hft.stuttgart.citydoctor2.check.ModificationListener
;
import
de.hft.stuttgart.citydoctor2.check.ModificationListener
;
...
@@ -103,7 +103,7 @@ public class HealMissingSolid implements HealingMethod {
...
@@ -103,7 +103,7 @@ public class HealMissingSolid implements HealingMethod {
private
List
<
Polygon
>
collectPolygons
(
CityObject
co
)
{
private
List
<
Polygon
>
collectPolygons
(
CityObject
co
)
{
List
<
Polygon
>
polygons
=
new
ArrayList
<>();
List
<
Polygon
>
polygons
=
new
ArrayList
<>();
Abstract
Check
polygonCheck
=
new
Abstract
Check
()
{
Abstract
Visitor
polygonCheck
=
new
Abstract
Visitor
()
{
@Override
@Override
public
void
check
(
Polygon
p
)
{
public
void
check
(
Polygon
p
)
{
if
(!
p
.
isLink
())
{
if
(!
p
.
isLink
())
{
...
...
CityDoctorParent/Extensions/CityDoctorHealerGenetic/src/test/java/de/hft/stuttgart/citydoctor2/healer/genetic/NonPlanarGenetic.java
View file @
74cdade3
...
@@ -36,10 +36,8 @@ import java.util.Map.Entry;
...
@@ -36,10 +36,8 @@ import java.util.Map.Entry;
import
java.util.Random
;
import
java.util.Random
;
import
java.util.Set
;
import
java.util.Set
;
import
org.junit.Test
;
import
Jama.EigenvalueDecomposition
;
import
Jama.EigenvalueDecomposition
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Check
;
import
de.hft.stuttgart.citydoctor2.check.Abstract
Visitor
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.CheckError
;
import
de.hft.stuttgart.citydoctor2.check.Checker
;
import
de.hft.stuttgart.citydoctor2.check.Checker
;
import
de.hft.stuttgart.citydoctor2.check.ValidationConfiguration
;
import
de.hft.stuttgart.citydoctor2.check.ValidationConfiguration
;
...
@@ -448,7 +446,7 @@ public class NonPlanarGenetic {
...
@@ -448,7 +446,7 @@ public class NonPlanarGenetic {
private
Polygon
findPolygonInFeature
(
CityObject
copy
,
Polygon
polygon
)
{
private
Polygon
findPolygonInFeature
(
CityObject
copy
,
Polygon
polygon
)
{
Polygon
[]
result
=
new
Polygon
[
1
];
Polygon
[]
result
=
new
Polygon
[
1
];
copy
.
accept
(
new
Abstract
Check
()
{
copy
.
accept
(
new
Abstract
Visitor
()
{
@Override
@Override
public
void
check
(
Polygon
p
)
{
public
void
check
(
Polygon
p
)
{
...
...
Prev
1
2
Next
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment