fixed a bug where a degenerate triangle causing the all polygons wrong...

fixed a bug where a degenerate triangle causing the all polygons wrong orientation check to report false positives

CityDoctorParent/CityDoctorValidation/src/main/java/de/hft/stuttgart/citydoctor2/checks/geometry/AllPolygonsWrongOrientationCheck.java

@@ -118,13 +118,15 @@ public class AllPolygonsWrongOrientationCheck extends Check {
 		// find the centroid of a triangle
 		Vector3d centroid = t.getCentroid();
 		// create a point outside of the geometry
-		Vector3d outsidePoint = bbox[0].minus(Vector3d.X, 5).minus(Vector3d.Y, 5).minus(Vector3d.Z, 5);
+		Vector3d outsideDif1 = new Vector3d(5, 5, 5);
+		Vector3d outsidePoint = bbox[0].minus(outsideDif1);
 		// create a second point outside of the geometry
 		// the check can fail if the building is exactly oriented so that the ray is
 		// parallel to a side of the building
 		// in order to avoid this we check two rays, if one of those says it is oriented
 		// correctly it is oriented correctly
-		Vector3d secondOutsidePoint = bbox[0].minus(Vector3d.X, 5).minus(Vector3d.Y, 10).minus(Vector3d.Z, 5);
+		Vector3d outsideDif2 = new Vector3d(7, 10, 5);
+		Vector3d secondOutsidePoint = bbox[0].minus(outsideDif2);
 		return checkIfGeometryIsWrongOriented(tessPolygons, centroid, outsidePoint)
 				|| checkIfGeometryIsWrongOriented(tessPolygons, centroid, secondOutsidePoint);
 	}
@@ -164,8 +166,8 @@ public class AllPolygonsWrongOrientationCheck extends Check {
 	}
 
 	private Triangle3d findSuitableTriangle(TesselatedPolygon p1) {
-		Triangle3d t = p1.getTriangles().get(0);
-		double maxArea = t.getArea();
+		Triangle3d t = null;
+		double maxArea = Double.NEGATIVE_INFINITY;
 		for (Triangle3d tri : p1.getTriangles()) {
 			double area = tri.getArea();
 			if (area > maxArea) {
@@ -173,6 +175,9 @@ public class AllPolygonsWrongOrientationCheck extends Check {
 				t = tri;
 			}
 		}
+		if (t == null) {
+			throw new IllegalStateException("No suitable triangle found");
+		}
 		return t;
 	}