Improvement: privacy provider change for recommendations table

Need to include the changes related to new recommendations table in privacy provider.

assigned to @32khsa1mst

created branch 6-improvement-privacy-provider-change-for-recommendations-table to address this issue

Create a limited moodle user. Test by running the course example. Then check the database entries e.g. in the recommendations table using any sql tool. Submit as limited user. Go to thje user's settings and look for data privacy. Issue an overview request. Then issue a delete request. Re-check the database.

added InProgress label

Unable to test the feature as no option for data requests under Privacy and Policies section in profile settings.

The admin user needs to go to the Site Administration/User/Privacy and Policies/Privacy Settings page. There, set at least "Contact the Privacy Officer", possibly also "Automatic data export request approval", maybe not "Autoamtic data deletion request approval".

that way it gives the option to make the data export and deletion request, when the user create the deletion request and privacy officer approves the request. it deletes the personal data of the user and it's account as well. but it does not delete submission, summary, results and recommendations data from the data base.

in line 245 it says ASSIGNSUBMISSION_FILE_FILEAREA which is missing the trailing _SUBMISSION from the constant definition. Maybe that is the reason.

Test setup: As per the documentation user must make a request for data overview and deletion from the same.

I have tried below mentioned approach based on the documentation still the option is not there.

Created a role "Privacy Officer (PO)" Assigned all required capabilities to the PO Assigned the PO role to the admin user created and submitted from the limited user.

to make the option visible we have to make changes as per your suggestions set at least "Contact the Privacy Officer", possibly also "Automatic data export request approval in privacy settings page under site administration

Found the issues in the delete personal data functionality and the export data, there were multiple bugs in the existing code

For delete functionality

1. 'ASSIGNSUBMISSION_DTA_FILEAREA_SUBMISSION' is a class level constant and it was imported as normal variable, instead it should be used with statement '\assignsubmission_dta\privacy\provider::ASSIGNSUBMISSION_DTA_FILEAREA_SUBMISSION'
2.      Data base fields in all 3 tables are 'assignment_id' & 'submission_id' but in all the queries in the provider they were referenced as 'assignmentid' & 'submissionid', due to the mismatch in the database field name and query fields no records were being deleted.

For Export data functionality

1. similar to above issues
2. get_files() function is not global function but were called as global function, had to be called as instance method.
3. Work-In-Progress: get_files() method defination and call gives mismatch type error for $submission (error message given below).
ERROR "provider::get_files(): Argument #1 ($submission) must be of type assignsubmission_dta\privacy\stdClass, stdClass given. "

removed InProgress label

added Test label

test and merged

closed