migrating to TypeScript

app.js → app.ts

-const express = require('express');
-const http = require('http');
-const path = require('path');
-const passport = require('passport');
-const morgan = require('morgan');
-const cookieParser = require('cookie-parser');
-const bodyParser = require('body-parser');
-const session = require('express-session');
-const errorhandler = require('errorhandler');
-const flash = require('express-flash-2');
-const fileUpload = require('express-fileupload');
-const helmet = require('helmet');
-const compression = require('compression');
-const methodOverride = require('method-override');
+import express from 'express';
+import path from 'path';
+import passport from 'passport';
+import morgan from 'morgan';
+import cookieParser from 'cookie-parser';
+import bodyParser from 'body-parser';
+import session from 'express-session';
+import flash from 'express-flash-2';
+import fileUpload from 'express-fileupload';
+import helmet from 'helmet';
+import compression from 'compression';
+import methodOverride from 'method-override';
+import dotenv from 'dotenv'
+
+dotenv.config();
 
 var env = process.env.NODE_ENV || 'testing';
 const config = require('./config/config')[env];
 const lang = 'DE';
 
 var app = express();
-
 app.set('port', config.app.port);
-app.set('views', __dirname + '/views');
+app.set('views', path.join( __dirname + '/views'));
 app.set('view engine', 'pug');
 
 // enable files upload
@@ -30,12 +30,25 @@ app.use(fileUpload({
     fileSize: 1000000 // 1 MB max. file size
   }
 }));
-
 app.use(methodOverride('_method'));
-app.use(helmet());
+app.use(
+  helmet.contentSecurityPolicy({
+    useDefaults: true,
+    directives: {
+      "font-src": ["'self'", "https://use.fontawesome.com"],
+      "img-src": ["'self'", "https://transfer.hft-stuttgart.de"],
+      "script-src": ["'self'", "https://code.jquery.com/jquery-3.3.1.min.js", "https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.14.7/umd/popper.min.js", 
+        "https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/js/bootstrap.min.js", "https://unpkg.com/bootstrap-show-password@1.2.1/dist/bootstrap-show-password.min.js"],
+      "style-src": ["'self'", "https://use.fontawesome.com/releases/v5.8.2/css/all.css"],
+      "frame-src": ["'self'"]
+    },
+    reportOnly: true,
+  })
+);
+
 app.use(compression());
 app.use(morgan('combined'));
-app.use(cookieParser());
+app.use(cookieParser(config.app.sessionSecret));
 app.use(bodyParser.json());
 app.use(bodyParser.urlencoded({extended: false}));
 app.use(express.static(path.join(__dirname, 'public')));
@@ -43,13 +56,11 @@ app.use((req, res, next) => {
   next();
 });
 
-app.use(session(
-  {
-    resave: true,
-    saveUninitialized: true,
-    secret: config.app.sessionSecret
-  }
-));
+app.use(session({
+  resave: true,
+  saveUninitialized: true,
+  secret: config.app.sessionSecret
+}));
 app.use(flash());
 app.use(passport.initialize());
 app.use(passport.session());
@@ -61,16 +72,16 @@ app.use(function(req, res, next) {
   next();
 });
 
-require('./routes/account')(app, config, passport, lang);
 require('./routes/public')(app, config, lang);
+require('./routes/account')(app, config, passport, lang);
 
 // Handle 404
-app.use(function (req, res) {
+app.use(function (req:any, res:any) {
   res.status(404).render(lang+'/404')
 })
 
 // Handle 500 - any server error
-app.use(function (err, req, res, next) {
+app.use(function (err:any, req:any, res:any, next:any) {
   console.error(err.stack)
   res.status(500).render(lang+'/500', {
     error: err

classes/project.js → classes/project.ts

 class Project {
-    constructor(ownerGitlabId, id, name, desc, logo, path) {
+    ownerGitlabId:number
+    name:string
+    desc:string
+    id?:number
+    logo?:string
+    path?:string
+    
+    constructor(ownerGitlabId:number, name:string, desc:string, id?:number, logo?:string, path?:string) {
         this.ownerGitlabId = ownerGitlabId
-        this.id = id
         this.name = name
         this.desc = desc
+        this.id = id
         this.logo = logo
         this.path = path
     }
@@ -28,24 +35,24 @@ class Project {
         return this.path
     }
     // setter
-    setOwnerGitlabId(newOwnerGitlabId){
+    setOwnerGitlabId(newOwnerGitlabId:number){
         this.ownerGitlabId = newOwnerGitlabId
     }
-    setId(newId) {
+    setId(newId:number) {
         this.id = newId
     }
-    setName(newName) {
+    setName(newName:string) {
         this.name = newName
     }
-    setDesc(newDesc) {
+    setDesc(newDesc:string) {
         this.desc = newDesc
     }
-    setLogo(newLogoUrl) {
+    setLogo(newLogoUrl:string) {
         this.logo = newLogoUrl
     }
-    setPath(newPath) {
+    setPath(newPath:string) {
         this.path = newPath
     }
 }
 
-module.exports = Project
\ No newline at end of file
+export = Project
\ No newline at end of file

classes/repo.js

-const Project = require("./project");
-
-class Repo extends Project {
-    constructor(ownerGitlabId, id, name, desc, logo, path) {
-        super(ownerGitlabId, id, name, desc, logo, path)
-    }
-}
-
-module.exports = Repo
\ No newline at end of file

classes/repo.ts

+import Project from "./project"
+
+class Repo extends Project {
+    constructor(ownerGitlabId:number, name:string, desc:string, id?:number, logo?:string, path?:string) {
+        super(ownerGitlabId, name, desc, id, logo, path)
+    }
+}
+
+export = Repo
\ No newline at end of file

classes/user.js → classes/user.ts

 class User {
-    constructor(id, email, salutation, title, firstName, lastName, industry, organisation, speciality, is_m4lab_idp, gitlabUserId, verificationStatus) {
-        this.id = id
-        this.email = email
-        this.salutation = salutation
-        this.title = title
-        this.firstName = firstName
-        this.lastName = lastName
-        this.industry = industry
-        this.organisation = organisation
-        this.speciality = speciality
-        this.is_m4lab_idp = is_m4lab_idp // 1 or 0
-        this.gitlabUserId = gitlabUserId
-        this.verificationStatus = verificationStatus
+    id:number
+    email:string
+    salutation:string // should be enum
+    title:string // should be enum
+    firstName:string
+    lastName:string
+    industry:string
+    organisation:string
+    speciality:string
+    is_m4lab_idp:number // 1 or 0
+    verificationStatus:number // 1 or 0 - // should be boolean
+    gitlabUserId?:number
+
+    constructor(id:number, email:string, salutation:string, title:string, firstName:string, lastName:string, industry:string, organisation:string,
+        speciality:string, is_m4lab_idp:number, verificationStatus:number, gitlabUserId?:number) {
+            this.id = id
+            this.email = email
+            this.salutation = salutation
+            this.title = title
+            this.firstName = firstName
+            this.lastName = lastName
+            this.industry = industry
+            this.organisation = organisation
+            this.speciality = speciality
+            this.is_m4lab_idp = is_m4lab_idp
+            this.verificationStatus = verificationStatus
+            this.gitlabUserId = gitlabUserId
     }
 
     // getter
@@ -27,48 +41,48 @@ class User {
     getIdpStatus() {
         return this.is_m4lab_idp
     }
-    getGitlabUserId() {
-        return this.gitlabUserId
-    }
     getVerificationStatus() {
         return this.verificationStatus
     }
+    getGitlabUserId() {
+        return this.gitlabUserId
+    }
     // setter
-    setEmail(email) {
+    setEmail(email:string) {
         this.email = email
     }
-    setSalutation(salutation) {
+    setSalutation(salutation:string) {
         this.salutation = salutation
     }
-    setTitle(title) {
+    setTitle(title:string) {
         this.title = title
     }
-    setFirstName(firstName) {
+    setFirstName(firstName:string) {
         this.firstName = firstName
     }
-    setLastName(lastName) {
+    setLastName(lastName:string) {
         this.lastName = lastName
     }
-    setIndustry(industry) {
+    setIndustry(industry:string) {
         this.industry = industry
     }
-    setOrganisation(organisation) {
+    setOrganisation(organisation:string) {
         this.organisation = organisation
     }
-    setSpeciality(speciality) {
+    setSpeciality(speciality:string) {
         this.speciality = speciality
     }
-    setM4lab_idp(m4lab_idp) {
-        this.m4lab_idp = m4lab_idp
-    }
-    setGitlabUserId(newGitlabUserId) {
-        this.gitlabUserId = newGitlabUserId
+    setM4lab_idp(m4lab_idp:number) {
+        this.is_m4lab_idp = m4lab_idp
     }
-    setVerificationStatus(verificationStatus) {
+    setVerificationStatus(verificationStatus:number) {
         this.verificationStatus = verificationStatus
     }
+    setGitlabUserId(newGitlabUserId:number) {
+        this.gitlabUserId = newGitlabUserId
+    }
 
-    updateProfile(newSalutation, newTitle, newFirstname, newLastname, newEmail, newOrganisation, newIndustry, newSpeciality) {
+    updateProfile(newSalutation:string, newTitle:string, newFirstname:string, newLastname:string, newEmail:string, newOrganisation:string, newIndustry:string, newSpeciality:string) {
         this.salutation = newSalutation
         this.title = newTitle
         this.firstName = newFirstname
@@ -80,4 +94,4 @@ class User {
     }
 }
 
-module.exports = User
\ No newline at end of file
+export = User
\ No newline at end of file

classes/website.js

-const Project = require("./project");
-
-class Website extends Project {
-    constructor(ownerGitlabId, id, name, desc, logo, path) {
-        super(ownerGitlabId, id, name, desc, logo, path)
-    }
-}
-
-module.exports = Website
\ No newline at end of file

classes/website.ts

+import Project from "./project"
+
+class Website extends Project {
+    constructor(ownerGitlabId:number, name:string, desc:string, id?:number, logo?:string, path?:string) {
+        super(ownerGitlabId, name, desc, id, logo, path)
+    }
+}
+
+export = Website
\ No newline at end of file

config/config.js → config/config.ts

-module.exports = {
+export = {
   development: {
     app: {
       name: 'User Account Management',
@@ -28,7 +28,7 @@ module.exports = {
       host: 'mailhost',  // hostname
       secureConnection: false,        // TLS requires secureConnection to be false
       port: 587,                      // port for secure SMTP
-      TLS: true,                      // sets requireTLS
+      TLS: true,
       authUser: 'mailuser',
       authPass: 'mailpass',
       tlsCiphers: 'SSLv3',
@@ -67,7 +67,7 @@ module.exports = {
       host: 'mailhost',  // hostname
       secureConnection: false,        // TLS requires secureConnection to be false
       port: 587,                      // port for secure SMTP
-      TLS: true,                      // sets requireTLS
+      TLS: true,
       authUser: 'mailuser',
       authPass: 'mailpass',
       tlsCiphers: 'SSLv3',
@@ -77,4 +77,4 @@ module.exports = {
       token_readWriteProjects: 'token-goes-here'
     }
   }
-}
+}
\ No newline at end of file

config/const.js → config/const.ts

-module.exports = {
+export = {
 
     mailSignature: 'Mit den besten Grüßen,<br/>das Transferportal-Team der HFT Stuttgart<br/><br/>' +
         'Transferportal der Hochschule für Technik Stuttgart<br/>' +

config/dbconn.js → config/dbconn.ts

-const mysql = require('mysql')
+import mysql from 'mysql'
 
-var env = process.env.NODE_ENV || 'testing';
+var env = process.env.NODE_ENV || 'testing'
 const config = require('./config')[env]
 
 // ==== USER ACOOUNT DB CONNECTION ====
@@ -14,7 +14,7 @@ var userConnection = mysql.createConnection({
 })
 
 userConnection.connect(function(err) {
-    if (err) throw err;
+    if (err) throw err
 })
 userConnection.query('USE '+config.database.dbUser)
 
@@ -52,7 +52,7 @@ var projectConnection = mysql.createConnection({
 })
 
 projectConnection.connect(function(err) {
-    if (err) throw err;
+    if (err) throw err
 })
 projectConnection.query('USE '+config.database.dbProject)
 
@@ -61,4 +61,4 @@ var connection = {
     project: projectConnection
 }
 
-module.exports = connection
\ No newline at end of file
+export = connection
\ No newline at end of file

config/dbconn2.js → config/dbconn2.ts

-const mysql = require('mysql2')
+import mysql from 'mysql2'
 
-var env = process.env.NODE_ENV || 'testing';
+var env = process.env.NODE_ENV || 'testing'
 const config = require('./config')[env]
 
 // ==== USER ACOOUNT DB CONNECTION ====
@@ -14,7 +14,7 @@ var userConnection = mysql.createConnection({
 })
 
 userConnection.connect(function(err) {
-    if (err) throw err;
+    if (err) throw err
 })
 userConnection.query('USE '+config.database.dbUser)
 
@@ -52,7 +52,7 @@ var projectConnection = mysql.createConnection({
 })
 
 projectConnection.connect(function(err) {
-    if (err) throw err;
+    if (err) throw err
 })
 projectConnection.query('USE '+config.database.dbProject)
 
@@ -61,4 +61,4 @@ var connection = {
     project: projectConnection
 }
 
-module.exports = connection
\ No newline at end of file
+export = connection
\ No newline at end of file

config/mailer.js

-const nodemailer = require('nodemailer');
-const nodemailerNTLMAuth = require('nodemailer-ntlm-auth');
-
-
-var env = process.env.NODE_ENV || 'testing';
-const config = require('./config')[env]
-
-var smtpTransport = nodemailer.createTransport({
-    host: config.mailer.host,
-    secure: config.mailer.secureConnection,
-    port: config.mailer.port,
-    requireTLS: config.mailer.TLS,
-    auth: {
-      type: 'custom',
-      method: 'NTLM',
-      user: config.mailer.authUser,
-      pass: config.mailer.authPass,
-     options: {
-        domain: 'ad'
-      }
-    },
-    customAuth:{
-        NTLM: nodemailerNTLMAuth
-    }
-});
-  
-var mailOptions = {
-    to: "",
-    from: config.mailer.from,
-    subject: "",
-    text: ""
-};
-
-var mailer = {
-    transport: smtpTransport,
-    options: mailOptions
-}
-
-module.exports = mailer

config/mailer.ts

+const nodemailer = require('nodemailer')
+const nodemailerNTLMAuth = require('nodemailer-ntlm-auth')
+
+var env = process.env.NODE_ENV || 'testing'
+const config = require('./config')[env]
+
+var smtpTransporter = nodemailer.createTransport({
+  host: config.mailer.host,
+  secure: config.mailer.secureConnection,
+  port: config.mailer.port,
+  requireTLS: config.mailer.TLS,
+  auth: {
+    type: 'custom',
+    method: 'NTLM',
+    user: config.mailer.authUser,
+    pass: config.mailer.authPass,
+    options: {
+      domain: 'ad'
+    }
+  },
+  customAuth:{
+    NTLM: nodemailerNTLMAuth
+  }
+});
+
+var mailOptions:any = {
+    to: "",
+    cc: "",
+    from: config.mailer.from,
+    subject: "",
+    text: "",
+    html: ""
+}
+
+var mailer:any = {
+    transporter: smtpTransporter,
+    options: mailOptions
+}
+
+export = mailer
\ No newline at end of file

functions/gitlab.js → functions/gitlab.ts

+import axios from 'axios'
+import fs from 'fs'
+import formData from 'form-data'
+
 var env = process.env.NODE_ENV || 'testing'
 const config = require('../config/config')[env]
-const axios = require('axios')
-const fs = require('fs')
-var formData = require('form-data')
 
 var gitlab = {
-    // todo: GraphQL currentUser
-
-    getUserByEmail: async function(email) {
+    getUserByEmail: async function(email:string) {
         return axios({
             method: 'get',
             url: 'https://transfer.hft-stuttgart.de/gitlab/api/v4/users?search='+email,
@@ -15,9 +14,12 @@ var gitlab = {
                 'Authorization': 'Bearer '+config.gitlab.token_readWriteProjects}
         })
         .then(res => res.data[0])
-        .catch(err => console.error(err))
+        .catch(function(err){
+            console.error(err)
+            return null
+        })
     },
-    createNewPages: async function(newPagesData, newLogoFile, template) {
+    createNewPages: async function(newPagesData:any, newLogoFile:string, template:any) {
         let data = new formData()
         data.append('avatar', fs.createReadStream(newLogoFile))
 
@@ -32,16 +34,15 @@ var gitlab = {
             },
             data: data
         })
-        .then(res => res = {
-            error: false,
-            data: res.data
-        })
-        .catch(err => res = {
-            error: true,
-            data: err.response.data
+        .then(res => res.data)
+        .catch(function(err) {
+            console.error("ERR Status: "+err.response.status)
+            console.error("ERR Name: "+err.response.data.message.name)
+            console.error("ERR Path: "+err.response.data.message.path)
+            return err.response
         })
     },
-    updateProject: async function(updatedProjectData, newLogoFile){
+    updateProject: async function(updatedProjectData:any, newLogoFile:string){
         let data = new formData()
         if (newLogoFile) {
             data.append('avatar', fs.createReadStream(newLogoFile))
@@ -57,16 +58,16 @@ var gitlab = {
             },
             data : data
         })
-        .then(res => res = {
-            error: false,
-            data: res.data
-        })
-        .catch(err => res = {
-            error: true,
-            data: err.response.data
+        //.then(res => res.data[0])
+        .then(res => res.data)
+        .catch(function(err){
+            console.error("ERR Status: "+err.response.status)
+            console.error("ERR Name: "+err.response.data.message.name)
+            console.error("ERR Path: "+err.response.data.message.path)
+            return err.response
         })
     },
-    deleteProjectById: function(projectId){
+    deleteProjectById: function(projectId:number){
         // https://docs.gitlab.com/ee/api/projects.html#delete-project
         return axios({
             method: 'delete',
@@ -75,16 +76,15 @@ var gitlab = {
                 'Authorization': 'Bearer '+config.gitlab.token_readWriteProjects 
             }
         })
-        .then(res => res = {
-            error: false,
-            data: res.data
-        })
-        .catch(err => res = {
-            error: true,
-            data: err.response.data
+        .then(res => true)
+        .catch(function(err) {
+            console.error("ERR Status: "+err.response.status)
+            console.error("ERR Name: "+err.response.data.message.name)
+            console.error("ERR Path: "+err.response.data.message.path)
+            return false
         })
     },
-    getUserProjects: async function(gitlabUserId) {
+    getUserProjects: async function(gitlabUserId:number) {