Commit 1310568f authored by Luna Riegel's avatar Luna Riegel
Browse files

Style: Remove completed TODOs

parent 5e19ae60
...@@ -169,7 +169,6 @@ public class CityGmlParser { ...@@ -169,7 +169,6 @@ public class CityGmlParser {
} }
return context; return context;
} }
//TODO: Implement resolving of library objects with database
/** /**
* Parses a given CityGML file and collects the contained CityObject Features in a {@link CityDoctorModel}. * Parses a given CityGML file and collects the contained CityObject Features in a {@link CityDoctorModel}.
...@@ -601,7 +600,6 @@ public class CityGmlParser { ...@@ -601,7 +600,6 @@ public class CityGmlParser {
}else if (!cdModel.containsGmlId(id)){ }else if (!cdModel.containsGmlId(id)){
cgmlModel.getCityObjectMembers().add(new AbstractCityObjectProperty(aco)); cgmlModel.getCityObjectMembers().add(new AbstractCityObjectProperty(aco));
} }
// TODO: add check if aco was parsed successfully, add aco to cmodel if it wasnt
} }
} }
......
...@@ -97,7 +97,6 @@ public class BoundingBoxCalculator { ...@@ -97,7 +97,6 @@ public class BoundingBoxCalculator {
* @return the bounding box of the model * @return the bounding box of the model
*/ */
public static BoundingBox calculateBoundingBox(CityDoctorModel model) { public static BoundingBox calculateBoundingBox(CityDoctorModel model) {
// TODO: Rework to Visitor
MinMaxExtentVisitor mima = new MinMaxExtentVisitor(); MinMaxExtentVisitor mima = new MinMaxExtentVisitor();
model.accept(mima); model.accept(mima);
......
...@@ -51,8 +51,6 @@ import de.hft.stuttgart.citydoctor2.parser.ParserConfiguration; ...@@ -51,8 +51,6 @@ import de.hft.stuttgart.citydoctor2.parser.ParserConfiguration;
public class BoundarySurfaceTest { public class BoundarySurfaceTest {
//Todo: Check this class for rework potential with the new Visitors
@Test @Test
public void testVisitorPropagation() { public void testVisitorPropagation() {
BoundarySurface bs = new BoundarySurface(SurfaceFeatureType.BUILDING, BoundarySurfaceType.WALL, null); BoundarySurface bs = new BoundarySurface(SurfaceFeatureType.BUILDING, BoundarySurfaceType.WALL, null);
......
...@@ -51,7 +51,6 @@ import de.hft.stuttgart.citydoctor2.utils.visitors.UnsetGeometriesVisitor; ...@@ -51,7 +51,6 @@ import de.hft.stuttgart.citydoctor2.utils.visitors.UnsetGeometriesVisitor;
public class BridgeObjectTest { public class BridgeObjectTest {
//TODO: Rework this class with the new Visitors
@Test @Test
public void testAccept() { public void testAccept() {
......
...@@ -26,7 +26,6 @@ import static org.mockito.Mockito.mock; ...@@ -26,7 +26,6 @@ import static org.mockito.Mockito.mock;
public class VegetationTest { public class VegetationTest {
//TODO: Recreate geometries tests
@Test @Test
public void testContainsError() { public void testContainsError() {
......
...@@ -1899,7 +1899,7 @@ public class CityDoctorController { ...@@ -1899,7 +1899,7 @@ public class CityDoctorController {
public void delete(TreeItem<Renderable> selectedItem) { public void delete(TreeItem<Renderable> selectedItem) {
if (model == null) { if (model == null) {
return; return;
}/* TODO: Rework this properly via Renderable implementation }/* Old debug function, would first need a refactor due to the RenderNode and GeoDB reworks
Renderable render = selectedItem.getValue(); Renderable render = selectedItem.getValue();
if (render instanceof BuildingNode node) { if (render instanceof BuildingNode node) {
model.getBuildings().remove(node.getBuilding()); model.getBuildings().remove(node.getBuilding());
......
...@@ -801,10 +801,13 @@ public class MainWindow extends Application { ...@@ -801,10 +801,13 @@ public class MainWindow extends Application {
}); });
menu.getItems().add(copyToClipboardOption); menu.getItems().add(copyToClipboardOption);
/* Was used for debugging the repair module, functionless since the RenderNode rework.
* Commented out for now, might be needed later on again
MenuItem deleteOption = new MenuItem(Localization.getText("MainWindow.delete")); MenuItem deleteOption = new MenuItem(Localization.getText("MainWindow.delete"));
deleteOption.setOnAction(ae -> controller.delete(featureView.getSelectionModel().getSelectedItem())); deleteOption.setOnAction(ae -> controller.delete(featureView.getSelectionModel().getSelectedItem()));
menu.getItems().add(deleteOption); menu.getItems().add(deleteOption);
featureView.setContextMenu(menu); featureView.setContextMenu(menu);
*/
} }
public void fetchCopyAction(Renderable node) { public void fetchCopyAction(Renderable node) {
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment