Fix: Runtime error if feature retrieval failed

CityDoctorParent/CityDoctorModel/src/main/java/de/hft/stuttgart/citydoctor2/check/error/MisalignedConnectionError.java

@@ -24,7 +24,7 @@ public class MisalignedConnectionError implements CheckError {
 
 
     public enum MisalignmentType{
-        BENT, SHEARED, HANGING, UNKNOWN
+        BENT, SHEARED, UNKNOWN
     }
 
     public MisalignedConnectionError(Geometry subjectGeom, CityObject subject, GmlId candidateGmlId,

CityDoctorParent/Extensions/CityDoctorGUI/src/main/java/de/hft/stuttgart/citydoctor2/gui/ListErrorVisitor.java

@@ -49,18 +49,24 @@ import de.hft.stuttgart.citydoctor2.check.error.SurfaceUnfragmentedError;
 import de.hft.stuttgart.citydoctor2.check.error.TooFewPolygonsError;
 import de.hft.stuttgart.citydoctor2.check.error.UnknownCheckError;
 import de.hft.stuttgart.citydoctor2.check.error.XMLValidationError;
+import de.hft.stuttgart.citydoctor2.datastructure.CityObject;
 import de.hft.stuttgart.citydoctor2.datastructure.Edge;
+import de.hft.stuttgart.citydoctor2.datastructure.GmlId;
 import de.hft.stuttgart.citydoctor2.datastructure.LinearRing;
 import de.hft.stuttgart.citydoctor2.datastructure.Vertex;
 import de.hft.stuttgart.citydoctor2.utils.PolygonIntersection;
 import javafx.scene.paint.Color;
 
+import java.util.function.Function;
+
 public class ListErrorVisitor implements ErrorVisitor {
-	
+
 	private HighlightController controller;
+	private final Function<GmlId, CityObject> cityObjectResolver;
 
-	public ListErrorVisitor(HighlightController controller) {
+	public ListErrorVisitor(HighlightController controller, Function<GmlId, CityObject> cityObjectResolver) {
 		this.controller = controller;
+		this.cityObjectResolver = cityObjectResolver;
 	}
 
 	@Override
@@ -316,6 +322,11 @@ public class ListErrorVisitor implements ErrorVisitor {
 
 	@Override
 	public void visit(MisalignedConnectionError err){
-		//TODO: Implement highlighting
+		controller.highlight(err.getSubjectGeom());
+		try {
+			controller.addObjectSkeletonHighlight(cityObjectResolver.apply(err.getCandidateGmlId()));
+		} catch (RuntimeException e) {
+			// candidate feature could not be resolved (e.g. not loaded in this session)
+		}
 	}
 }

CityDoctorParent/Extensions/CityDoctorGUI/src/main/java/de/hft/stuttgart/citydoctor2/gui/Renderer.java

@@ -53,7 +53,7 @@ public class Renderer {
         this.mainWindow = mainWindow;
         this.highlightController = highlightController;
         loadingDialog = new LoadingInfoDialog(mainWindow.getMainStage());
-        errVisitor = new ListErrorVisitor(highlightController);
+        errVisitor = new ListErrorVisitor(highlightController, mainWindow::retrieveCityObject);
     }
 
     private boolean triangleVisible(TriangleMeta m) {
@@ -449,7 +449,11 @@ public class Renderer {
 
     public void addCandidateSkeletonHighlight(GmlId candidateId){
         // TODO: Rework to opengl
-        highlightController.addObjectSkeletonHighlight(mainWindow.retrieveCityObject(candidateId));
+        try {
+            highlightController.addObjectSkeletonHighlight(mainWindow.retrieveCityObject(candidateId));
+        } catch (RuntimeException e) {
+            // candidate feature could not be resolved (e.g. not loaded in this session)
+        }
     }
 
     public void highlight(Polygon p) {

CityDoctorParent/Extensions/CityDoctorHealerGUI/src/main/java/de/hft/stuttgart/citydoctor2/healer/gui/HealerController.java

@@ -74,8 +74,8 @@ public class HealerController {
 		this.nextHighlights = new HighlightController(healerView.getNextViewport());
 		currentHighlights.setCenterSupplier(() -> currentScene == null ? new double[3] : currentScene.center());
 		nextHighlights.setCenterSupplier(() -> nextScene == null ? new double[3] : nextScene.center());
-		currentErrorVisitor = new ListErrorVisitor(currentHighlights);
-		nextErrorVisitor = new ListErrorVisitor(nextHighlights);
+		currentErrorVisitor = new ListErrorVisitor(currentHighlights, id -> model.getCityObject(id));
+		nextErrorVisitor = new ListErrorVisitor(nextHighlights, id -> model.getCityObject(id));
 	}
 
 	/** Installs the current scene into the current viewport and applies the current view options. */