Skip to content
GitLab
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in
Toggle navigation
Menu
Open sidebar
CityDoctor
CityDoctor2
Commits
12d96d95
Commit
12d96d95
authored
Jul 29, 2024
by
Riegel
Browse files
Minor corrections to comments and test-case messages
parent
f9f4046f
Pipeline
#10027
passed with stage
in 1 minute and 8 seconds
Changes
2
Pipelines
2
Hide whitespace changes
Inline
Side-by-side
CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckFalsePositiveBigMeshTest.java
View file @
12d96d95
...
...
@@ -19,10 +19,10 @@ import de.hft.stuttgart.citydoctor2.parser.CityGmlParser;
import
de.hft.stuttgart.citydoctor2.parser.InvalidGmlFileException
;
/**
* Additional
T
est-
C
ases for
known F
alse
-P
ositive
s for
self
intersection.
* The
se tests use
building models
which
have big meshes
.
*
Excluded from Maven test-phase
due
to t
he l
imited mem
or
y
o
f the
* CI/CD-Runners.
* Additional
t
est-
c
ases for
testing found f
alse
p
ositive self
-
intersection
errors
.
* The building models
in these tests
have big meshes
,
*
and thus in
du
c
e
a spike in memory usage w
he
n
l
oaded
or o
n starting a check.
*
Excluded from Maven tests due to the limited memory of the
CI/CD-Runners.
*
* @author Riegel
*/
...
...
@@ -40,7 +40,7 @@ public class SolidSelfIntCheckFalsePositiveBigMeshTest {
/*
* The examples have no actual self-intersections, but can contain other actual model defects.
* If an error is detected, it is thus required to check if the
*
F
alse
-P
ositive self-intersection triggered it.
*
f
alse
p
ositive self-intersection triggered it.
*/
if
(
building
.
containsAnyError
())
{
Geometry
buildingGeom
=
building
.
getGeometry
(
GeometryType
.
SOLID
,
Lod
.
LOD2
);
...
...
@@ -50,7 +50,8 @@ public class SolidSelfIntCheckFalsePositiveBigMeshTest {
CheckResult
cr
=
buildingGeom
.
getCheckResult
(
check
);
assertNotNull
(
cr
);
//Ensure that the found error is not a self-intersection error
assertEquals
(
"Known False-Positive self-intersection was detected as error"
,
ResultStatus
.
OK
,
cr
.
getResultStatus
());
assertEquals
(
"False-positive self-intersection should not be detected by self-intersection check"
,
ResultStatus
.
OK
,
cr
.
getResultStatus
());
}
}
...
...
CityDoctorParent/CityDoctorValidation/src/test/java/de/hft/stuttgart/citydoctor2/checks/geometry/SolidSelfIntCheckTest.java
View file @
12d96d95
...
...
@@ -90,7 +90,7 @@ public class SolidSelfIntCheckTest {
/*
* The examples have no actual self-intersections, but can contain other actual model defects.
* If an error is detected, it is thus required to check if the
*
F
alse
-P
ositive self-intersection triggered it.
*
f
alse
p
ositive self-intersection triggered it.
*/
if
(
building
.
containsAnyError
())
{
Geometry
buildingGeom
=
building
.
getGeometry
(
GeometryType
.
SOLID
,
Lod
.
LOD2
);
...
...
@@ -100,7 +100,8 @@ public class SolidSelfIntCheckTest {
CheckResult
cr
=
buildingGeom
.
getCheckResult
(
check
);
assertNotNull
(
cr
);
//Ensure that the found error is not a self-intersection error
assertEquals
(
"Known False-Positive self-intersection was detected as error"
,
ResultStatus
.
OK
,
cr
.
getResultStatus
());
assertEquals
(
"False-positive self-intersection should not be detected by self-intersection check"
,
ResultStatus
.
OK
,
cr
.
getResultStatus
());
}
}
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment